Ticket #100 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

custom smileys

Reported by: MARS_3-142 Owned by: seanegan
Milestone: Component: pidgin (gtk)
Version: 2.0 Keywords:
Cc:

Description

I tried to export the custom smiley from msn live.

Someone send me an message and embeddet this text are some custom smileys (or other pics). A right click doesn't allow me to copy or export these pics. I can't find them on my harddrive.

I'm using GAIM 2.0.0beta6 (under WinXP) and GAIM SVN under openSUSE (but I didn't tried it there).

Attachments

screenshot_gaim.jpg (83.6 kB) - added by MARS_3-142 3 years ago.
screenshot custom smileys (WinXP)
filename_in_save_smile.patch (0.8 kB) - added by salinasv 3 years ago.
patch to fill the default filename with the emoticon name

Change History

Changed 3 years ago by MARS_3-142

screenshot custom smileys (WinXP)

  Changed 3 years ago by salinasv

This is part of the doing job in the SF Patch 1429899 by gloomer and I. Now I'm on my final exams in school but just finishing that I will open a ticket here with the updated patch.

The patch is for sending emoticons but the next stage of the patch will be a way to save the received emoticons from the gtkconv

  Changed 3 years ago by lschiere

  • owner set to seanegan

We can receive but not create custom msn smileys. GtkIMHtml cannot handle creation at the moment.

  Changed 3 years ago by salinasv

I have not try anything about catching the received emoticon but I have noticed in the debug messages that when I receive a custom emoticon somewhere is created a pixbuf where the emoticon is loaded and the text that the sender user have to identify that emoticone are shown in the debug to.

So I think that somewhere between that pixbuf and the emoticon id displayed in the debug windows could be catched Maybe I'm wrong I'm not familiar with pixbuf and that part of the code

  Changed 3 years ago by Twain28

I'm currently using Gaim b6 with this patch applied, and it really works flawlessly (apart from a slight load time when emots are too much). It would be great to have it back on Pidgin soon! I pointed Glommer this ticket, and he said he'll take a look....hope this helps you. Tw@in 28

  Changed 3 years ago by salinasv

I was using gaim svn with this patch applied since last december when I took part of the work here and I got a little crash when someone sends some strange (I don't know yet what kind of) emoticon I have the core files to double check what can be wrong but as I have said I'm on my final exams in school... I finish this stuff in 1 week then I will upgrade the patch to the new namespace and stuff to get it working as it is now in pidgin (rlaager told us that we should apply the patch to the msnp14 branch so I will do that)

I will be glad if you can send me all the flaws you can see in the patch to be able to correct it but all of this after week =P

  Changed 3 years ago by Twain28

I'll keep an eye on this ticket and try your patch as soon as it comes out....nice to know it's going to be part of the msnp14 branch ('t was about time!).... Hope anyway you or Glommer can figure out something to save recieved custom emoticons. Oh, and "butt of the whale" for your finals too! =P Tw@in 28

  Changed 3 years ago by GothicAwakening

I have been using the Patch on gaim svn too without any problems, and am looking forward to having it for pidgin so I can get onto the latest version. Thanks for you hard work on getting this to work.

  Changed 3 years ago by Twain28

Any news abou it? Oh, don't know if it helps, but scrabbling in the revision depot I found THIS ONE .... so is the save msn custom emoticons feature finally being put in? Tw@in 28

  Changed 3 years ago by salinasv

Your are right, sadrul does the job and save me some time =P I just tested few minutes ago and it works fine, thanks for tell me about this, the revision is 78cb85fc0af3e11423725b7822e341ff4eef7fa

Now I'm actively working on the custom emoticon patch update but the msnp14 code have changed a lot, so I have to adapt each one of the patch to fit in it and I'm having problems working with that branch because I make it crash a lot =/

I don't know if I should open a new ticket or post here the patches when finish.. maybe some of the developers could tell me

will have news in a few days.

Changed 3 years ago by salinasv

patch to fill the default filename with the emoticon name

  Changed 3 years ago by salinasv

I noticed that when you save the emoticon the dialog doesn't keep the smiley name to be used te be the filename, so I got a patch that add smiley name to filename entry (attached here)

  Changed 3 years ago by sadrul

Saving received custom emoticons will be possible from the next release. Thanks to salinasv's patch, the filename field will be pre-filled with the text for the custom smiley.

follow-up: ↓ 13   Changed 3 years ago by rlaager

  • status changed from new to closed
  • resolution set to fixed

in reply to: ↑ 12 ; follow-up: ↓ 14   Changed 3 years ago by Twain28

Replying to rlaager: Ok, but sending? I don't understand why the ticket gets closed without salinasv even posting the updated send-custom-emots patch....does this mean Pidgin already can?Or it's something that will be put into another ticket (branch MSNP14)? _ Tw@in 28

in reply to: ↑ 13   Changed 3 years ago by rlaager

Replying to Twain28:

Replying to rlaager: Ok, but sending? I don't understand why the ticket gets closed without salinasv even posting the updated send-custom-emots patch

Read the description, realize it's completely unrelated to what you're asking about (saving received custom smileys != sending custom smileys), and then wait for a new ticket.

  Changed 3 years ago by Twain28

Woops!....I'm SO sorry, I didn't realize (I got misguided by referring to Glommer's old patch).....ok, I'll just wait for a new ticket about it....many thanks for pointing it to me....again my excuses.... _ Tw@in 28

  Changed 3 years ago by salinasv

just to let you know, there is sending custom emoticon stuff in #1187 so, feel free to test it

  Changed 3 years ago by msfbrasil

Hello there!!!

By now I'm using version 2.0.2 of Pidgin, and it seems the only thing it allows is to save the emoticon, and as a png file instead of gif. Besides, whether you type the same shortcut for the emoticon you received, the image is not presented on conversation window.

This is right? I mean, this is the only one functionality that will be available?

If you have intention to provide full emoticon functionality - like add new emoticons that will be showed up on the emoticons selection window, and be presented to me when I type the shortcut on the conversation window right after I added it - could someone please tell me when (on witch version) will this happen?

One more thing. On the source code, I've noticed a commentary indicating that an emoticon cache will be implemented on future. Can anyone give me some indication of when this will happen ?

Best regards, Mauro.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!