Patch for MSN crash caused by msn_switchboard_request

[hanzz]

Attached crash and log describes the problem:

MsnSwitchBoard *
msn_session_get_swboard(MsnSession *session, const char *username,
						MsnSBFlag flag)
{
....
		swboard = msn_switchboard_new(session);
		swboard->im_user = g_strdup(username);
		msn_switchboard_request_add_user(swboard, username);
....
	return swboard;
}

1. New switchboard is created

2. msn_switchboard_request(swboard); is called, but during this call there is problem with connection to MSN network and account is disconnected (switchboard is freed and no longer exists after that function)

3. non-existing swboard is used => crash

This is more global problem in prpl-msn implementation and my patch fixes just one occurrence, but I would say we can start with my change.

[salinasv]

It looks Ok to me.

[rekkanoryo]

With the new MSN code merged, is this patch still relevant? If so, it needs to be shipped in 2.7.10 or rejected.

[rekkanoryo]

The cmdproc.[ch] stuff in this patch rejects. Please submit an updated patch (or con Masca or QuLogic into fixing it and committing it before 2.7.10).

[shlomif]

Here is the patch forwarded for pidgin-monotone-HEAD.

[shlomif]

Hi, I forward ported the patch to the monotone HEAD (pidgin-2.9.0-and-above). Please apply it.

[masca@…]

(In [e4038d4f52e6856643df0bce1488a565385a851f]):
Fix a crash when the account is disconnected and we have requested a SB. (Hanzz, ported by shlomif)(Fixes #12431)