Ticket #14608 (closed patch: fixed)

Opened 5 months ago

Last modified 5 months ago

Clean up Sametime

Reported by: clokep Owned by: siege
Milestone: v2.10.1 Component: Sametime
Version: 2.9.0 Keywords:
Cc:

Description

While re-adding Sametime support to Instantbird I made Sametime compile with MSVC, Florian informed me that his changes of this type were accepted upstream.

This patch also adds in the Username Split that was removed at some point (I believe this was removed when the sametime plug-in was still part of a separate project on sourceforge).

I'm not sure how applicable it is, but our bug on the issue is: https://bugzilla.instantbird.org/show_bug.cgi?id=102

We have had reports that these changes work fine, although I'm not sure how backward compatible they are. I'm willing to put some effort into getting this upstream into libpurple, so let me know if things need to be changed.

Attachments

sametime.diff (8.5 kB) - added by clokep 5 months ago.
MSVC compatibility & usernamesplit

Change History

Changed 5 months ago by clokep

MSVC compatibility & usernamesplit

Changed 5 months ago by Robby

  • milestone changed from 2.10.1 to Patches Needing Review

Changed 5 months ago by rekkanoryo

I apologize for this patch sitting around for so long. Currently we have no one who is active in our development who knows anything about Sametime. That said, it compiles, so I'm shipping it.

Changed 5 months ago by Patrick Cloke

  • status changed from new to closed
  • resolution set to fixed
  • milestone changed from Patches Needing Review to 2.10.1

(In [0b7caf6b17815fe333d151369f26330d4c662bda]):
Fix up the Sametime prpl to play nice with Visual C++. This patch also puts back a username split that was removed just about forever ago. Fixes #14608.

Changed 5 months ago by Robby

  • milestone changed from 2.10.1 to v2.10.1
Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!