Pidgin

Ticket #1643 (closed defect: fixed)

Opened 3 years ago

Last modified 5 weeks ago

MSN File transfer doesn't close handle when file sending completes.

Reported by: Dedalus Owned by: khc
Milestone: 2.6.6 Component: MSN
Version: 2.0.1 Keywords: ft
Cc: itm

Description

I start a file transfert (msn messenger protocol) with my friend. When the transfert it is finish, i cannot delete the file because it is locked by Pidgin.

Ciao

Os: Windows XP sp2 Professional Edition

Change History

  Changed 3 years ago by datallah

  • owner datallah deleted
  • component changed from winpidgin (gtk) to libpurple
  • summary changed from File Transfert locked after transfert to MSN File transfer doesn't close handle when file sending completes.

  Changed 2 years ago by seanegan

  • owner set to khc
  • component changed from libpurple to MSN

  Changed 21 months ago by felipec

  • keywords ft added
  • owner changed from khc to felipec
  • status changed from new to assigned

  Changed 20 months ago by felipec

  • owner changed from felipec to khc
  • status changed from assigned to new

Sorry, I'm going to focus on a few set of bugs, fix them and then leave the project probably for good.

  Changed 17 months ago by datallah

Ticket #6969 has been marked as a duplicate of this ticket.

  Changed 15 months ago by bughunter2

Wise choice felipec...

follow-up: ↓ 8   Changed 14 months ago by bughunter2

Lame, that I got fed up with some bugs not being fixed doesn't give me the right to complain. Instead I should do something about it.

in reply to: ↑ 7   Changed 14 months ago by felipec

Replying to bughunter2:

Lame, that I got fed up with some bugs not being fixed doesn't give me the right to complain. Instead I should do something about it.

FWIW in msn-pecan we do value user feedback, there are 4 votes for this issue: http://code.google.com/p/msn-pecan/issues/detail?id=37

That is taken into consideration, and it's a requirement for the 0.1.0 milestone.

  Changed 14 months ago by bughunter2

Well I think I just overreacted a bit so that's why I posted my thoughts.

Anyway, great news =)

  Changed 10 months ago by datallah

Ticket #8915 has been marked as a duplicate of this ticket.

  Changed 8 months ago by itm

Hi, I can report experiencing the same bug transferring files through AIM on windows (pidgin release 2.5.6).

After sending a file I am unable to access or delete the containing directory.

  Changed 8 months ago by felipec

So either both msn and aim prpls are broken or the problem is in libpurple core. My bet is still on libpurple core.

  Changed 3 months ago by HorizonX

Bug confirmed on XP SP3 running pidgin 2.6.3. There are 2 distinct file-handle leaks of the containing directory after each transfer on AIM transfers.

  Changed 2 months ago by qulogic@…

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 2.6.5

(In [780ee14f6ced21de7257b3149c186223ab446d57]):
Don't call purple_xfer_start in msn_xfer_init. purple_xfer_start is called later after the other side accepts, and this second call clobbers the file handle. This file handle is leaked resulting in Pidgin appearing to lock the file stopping Windows from being able to delete it.

The changes from darkrain42's branch actually fixed the real file handle leak except for the addition of this one line.

Fixes #1643.

  Changed 5 weeks ago by darkrain42

  • milestone changed from 2.6.5 to 2.6.6

These were all pushed back a release due to the method by which the 2.6.5 release is being made.

Note: See TracTickets for help on using tickets.