Ticket #1977 (closed patch: fixed)

Opened 3 years ago

Last modified 22 months ago

right-to-left tooltips messed up.

Reported by: liorwohl Owned by: seanegan
Milestone: 2.5.3 Component: pidgin (gtk)
Version: 2.0.2 Keywords: rtl, tooltips, hebrew
Cc:

Description

when using gnome with rtl language- the away tooltips completely messed up in most (~90%) of the contacts.

Attachments

חסר-שם.png (156.6 kB) - added by liorwohl 3 years ago.
rtl-contact-tooltip.patch (1.6 kB) - added by db42 3 years ago.
fixes this problem
DSC00377.JPG (260.0 kB) - added by liorwohl 3 years ago.
DSC00378.JPG (29.1 kB) - added by liorwohl 3 years ago.
DSC00380.JPG (23.2 kB) - added by liorwohl 3 years ago.
completly blank... ):
rtl-contact-tooltip-better.patch (1.9 kB) - added by db42 2 years ago.
an improved version of the bug fix, should work ok now.
snapshot1.png (13.5 kB) - added by shlomil 2 years ago.
hebrew tooltips+latest patch
snapshot2.png (26.3 kB) - added by shlomil 2 years ago.
hebrew tooltips+latest patch+Picture

Change History

Changed 3 years ago by liorwohl

Changed 3 years ago by liorwohl

i still have the problem in pidgin 2.1

and i have checked in Gaim 2 beta (from ubuntu feisty) and there the tooltips look ok... so its a regression

Changed 3 years ago by db42

is there somewhere access to the code where he claims the program didn't exist ? (also msg to myself to try and fix it ).

Changed 3 years ago by db42

fixes this problem

Changed 3 years ago by db42

Now it works ok ?

Changed 3 years ago by seanegan

  • owner set to seanegan
  • status changed from new to assigned
  • type changed from defect to patch
  • milestone set to 2.2.1

Changed 3 years ago by seanegan

  • status changed from assigned to closed
  • resolution set to fixed

thanks!

Changed 3 years ago by seanegan

  • status changed from closed to reopened
  • resolution fixed deleted

the name still looks all screwed up.

Changed 3 years ago by db42

It seems to work here, can you show a screenshot ?

Changed 3 years ago by db42

can anybody please test this patch and report if it works for them (since it does seem to work for me). Also if not, I would appreciate screenshots of the faulty tooltips.

Changed 3 years ago by shlomil

Good job! This bug was on my TODO list :)

screenshot after db42 patch

(for some reason I was not able to attach the image to the bug :-| )

As you can see, the contact Alias/ICQ#/MSN-ID is still not aligned.

Changed 3 years ago by liorwohl

i tested again with pidgin 2.4 and the problem is still there...

Changed 3 years ago by liorwohl

Changed 3 years ago by liorwohl

Changed 3 years ago by liorwohl

completly blank... ):

Changed 2 years ago by rlaager

  • milestone set to Patches Needing Improvement

From the screenshots, it looks like this patch still needs some work.

Changed 2 years ago by db42

an improved version of the bug fix, should work ok now.

Changed 2 years ago by db42

Ok, i've looked into the problem again and have come up with a better solution hopefully, please test it and report any issues.

Changed 2 years ago by rlaager

  • milestone Patches Needing Improvement deleted

Changed 2 years ago by shlomil

hebrew tooltips+latest patch

Changed 2 years ago by shlomil

hebrew tooltips+latest patch+Picture

Changed 2 years ago by shlomil

Tested the patch and it worked great for me. (I did not review the code) patch utility reported an offset of 68 lines (patching into latest MTN)- patch probably needs a minor update.

Changed 2 years ago by shlomil

ping. A good time to accept this patch would be right about.... now?

Changed 22 months ago by db42

now that #4449 has been fixed, what about this ? :)

Changed 22 months ago by rlaager@…

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 2.5.3

(In [d33b4d42bee23e1d64289f3e7c83b182ef0e5a91]):
A patch from db42 to fix right-to-left text in tooltips. Fixes #1977

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!