Handle Left and Right arrow keys on Buddy List

[fmoo]

When the buddy list (treeview) has focus, pressing left/right should have the following functionality:

• If a 'Collapsed group' is selected
  • Left should do nothing
  • Right should expand the group.
• If an 'Expanded group' is selected
  • Left should collapse the group
  • Right should select the first item inside the group (if one is present)
• If a 'Contact' is selected
  • Left should select the Group node
  • right should do nothing(*)
• If an 'Expanded contact' is selected
  • Left should collapse the contact
  • Right should select the first buddy inside the contact
• If a 'Buddy (sub-contact)' is selected
  • Left should select the Contact
  • Right should do nothing.

(*) - Making this expand the contact might be really nice

[fmoo]

I botched the WikiFormatting again. Awesome

[fmoo]

According to ticket; right on contact will expand.

[fmoo]

Though: I thought this functionality was native to the GtkTreeview? ... and that it was in a previous version of gaim. Anybody know?

[chemistrydioxide]

When using left or right keys, Pidgin is beeping. In the regular unpatched version, this is understandable because they don't work. But in the patched version, Pidgin beeps every time I hit right or left, whether it made sense or not. Pidgin should only beep if collapsing or expanding is not possible.

[rekkanoryo]

Has there been any work on chemistrydioxide's issue in this patch?

[frasten]

Fixes the "beep" issue.

[frasten]

I've edited the patch, now it doesn't beep anymore when expanding/collapsing. Now it should be OK.

[rlaager]

(14:38:25) rlaager: fmoo: Why are you Fmoo in the about box and not fmoo? (14:39:38) rlaager: fmoo: More importantly, regarding #2111, why do we want code to make the arrow keys behave in that way? Assuming the feature itself is justified, the code in the updated patch seems good to commit. I haven't tested it to verify that it actually works, but it looks correct. :)

[rekkanoryo]

Accepting, rejecting, or requesting improvement of this patch is a blocker for the release of version 2.6.0.

[QuLogic]

Will commit later today or tomorrow if nobody else does.

[qulogic@…]

(In [0f35cd33aa18c3505d499dd84b75cce0a66f3988]):
Apply patch from Peter to handle the left and right arrow keys in the buddy list to expand and contract groups or contacts, plus a few leak fixes.

Fixes #2111.