Ticket #2923 (new defect)

Opened 3 years ago

Last modified 3 years ago

Remove _purple_oscar_convert()

Reported by: MarkDoliner Owned by: MarkDoliner
Milestone: 3.0.0 Component: AIM
Version: 2.1.1 Keywords:
Cc:

Description

We can remove the _purple_oscar_convert() function from util.c/util.h for libpurple 3.0.0.

Change History

Changed 3 years ago by rlaager

For the record: I looked at this and said, "We can remove it now, as it's an internal symbol." So I looked into doing that and found it is still called (or at least exists in the source code, I just did a grep).

Changed 3 years ago by MarkDoliner

Yeah, I think it's still called in the four places where we read in our xml files. And the function isn't actually static... it just starts with an underscore and the documentation tells plugins not to use it.

But it's not really harming anything. I think it'd be good to leave it in there until 3.0.0 regardless, so anyone upgrading from 1.5.0 will have working AIM/ICQ accounts.

Changed 3 years ago by seanegan

  • owner set to MarkDoliner
  • component changed from pidgin (gtk) to AIM
Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!