Changing groups with account disabled doubles buddies upon re-enabling

[imiganai]

Bit of a weird bug:
1) I have an MSN and AIM account. For various reasons I had AIM disabled.
2) I changed the names of a few of the groups
3) Multiple pidgin restarts later, I re-enabled the AIM account
4) That session, buddies appeared twice in lists, in the old category name and in the renamed category.
5) Assuming duplication, I deleted the old categories again
6) Upon next restart of Pidgin, the AIM buddies that had their category changed were deleted
7) Thanks to this I had to put them back by hand.

libpurple isn't splitting up group renames based on active accounts, it seems (easiest solution, especially in the case where different people use the same application and don't want one group rename affecting the other)

[bernmeister]

Does this still occur in 2.5.0?

[imiganai]

I just tried--this bug doesn't happen but it definitely doesn't perform as expected. 1) I currently have AIM, MSN, XMPP (Gchat), Yahoo, and Skype accounts set up. 2) I disabled AIM. 3) I renamed a group that had aim, skype, xmpp, and msn buddies in it. 4) No effect. The group name did not change. 5) I restarted pidgin 6) The group was now split into two groups, the old group and the renamed group. The only buddies that moved into the new group were the MSN buddies, and they lost their aliases. 7) Re-enabled AIM 8) The AIM buddies remained with the old group name, thankfully.

This probably has something to do with grouping by alias. Every contact in that group had an AIM address listed in addition to MSN, Skype, whatever.

[imiganai]

9) I merged the groups back to the OLD name and recombined the split contacts.
10) I restarted pidgin just to make sure
11) AIM buddies are duplicated, one under the old name and one under the new name. The other buddies have all moved to the NEW name, even though they seemed to be in the old name last time. One of the MSN contacts I had moved back to the old name showed up under the old group, but the other went into an MSN group called "Other Contacts". All contacts under the OLD name have split up into individual buddies.
12) I restart pidgin again...AIM buddies are still duplicated.
13) Out of fear for my buddy list, I restore the backed-up blist.xml
14) The MSN buddy that went to "other contacts" for some reason still appears in "other contacts", but everything else is back to normal under the OLD group name.

This is REALLY broken...

[bernmeister]

Just to confirm: you've tested this under 2.5.0/2.5.1 right?

[imiganai]

9 days ago was not yet 2.5.1, so 2.5.0 I believe.

[bernmeister]

I believe there's a fix for doubling-up buddies in the upcoming 2.6.0 - so can you please test on that and see if this is still an issue?

[darkrain42]

This isn't going to be fixed. This 'duplication' is different from the duplication scenarios I fixed for 2.6.0.

We probably shouldn't be moving buddies in offline accounts, even when renaming the group (such a rename should entail moving only buddies from online accounts or something), or we need to store that rename so that when a disabled account is enabled, the rename is then processed on the server.

[darkrain42]

Replying to darkrain42:

This isn't going to be fixed.

...in 2.6.0. As in, I don't believe it's fixed. I just realized that could be read as "we won't fix this".