GObjectification

[grim]

this has started on the branch im.pidgin.gobjectification

[xanderw]

i've been working on gobjectification, as some might know (or not).

these patches are basicly an update of grim's gobjectification branch to h:im.pidgin.pidgin (i.e. dc53960d0) with some extra ciphers found in i.p.p. they could be merged in a branch, which i could maintain (although i do not have write access to the mtn-repo) and then merged to i.p.p after we release 2.4.0.

i'll keep working on this, so i'd like some feedback on these patches

[sadrul]

Do we want/need to put all the cipher stuff in libpurple/cipher/?

[xanderw]

I certainly want to, but we don't have to. It does clean up libpurple/ considerably.

[sadrul]

Just to confirm, the attached patches include all the changes from im.pidgin.gobjectification upto c66007e731f462e98b703a91b0ae43a15ca9112d. Right?

[xanderw]

That is correct, yes.

[sadrul]

xanderw: What name do I use for you in our COPYRIGHT file?

[sadrul@…]

(In [afd0de98d28b3483b0ba8d34d6d2e067074edd3d]) A bunch of patches from xanderw to update the gobjectification branch with the changes in i.p.p: 0001-Move-ciphers-around.patch 0002-New-cipher-API.patch 0003-All-cipher-subclasses.patch 0004-Update-libpurple-and-tests.patch 0005-Updates-plugins.patch 0006-Updates-protocols.patch

Things compile and run, apparently. References #35.

[sadrul@…]

(In [760fcafe15614b682f788c4d95abe462277ed964]) Patch from xanderw to have some more cipher stuff. References #35.

[xanderw]

Replying to sadrul:

xanderw: What name do I use for you in our COPYRIGHT file?

Sorry for my late response (vacation is a good thing, you know ;) )

"Sanne Wouda", in the COPYRIGHT file will be fine, thank you.

I've got some more changes pending: circbuffer classes, eventloop (which should be split in two classes, timeout and input, I think) and uiops (which uses signals more extensively, don't know if this is the way to go, though).

[xanderw]

My new patches series, as promised. They apply to h:im.pidgin.gobjectification (88df81f5d)

Included are:

uiops circbuffer timeout some extra cipher changes

I'll work on the input class from eventloop.c next, and after that i'm going to get my hands dirty with the connection/account/serv stuff, that should be fun.... I'll probably do some smaller classes to keep me from going crazy.

Any comments are welcome

[xanderw]

new uiops class, see timeout class for example use

[xanderw]

new circbuff class

[QuLogic]

So I noticed you commented out a few things with '#if 0' in the header files. This sort of breaks the DBus code. I think once GObjectification is done, we can use GLib's DBus stuff, but for the time being I've attached a patch to the python code that ignores parts of headers that are commented out with '#if 0'.

[QuLogic]

Ignore sections in '#if 0'/'#endif' when looking for functions for DBus.

[sadrul@…]

(In [98e04213689606d731ff9c41d4bb7bba1ea5c264]):
Patch from QuLogic to make the dbus file generator ignore '#if 0'-ed stuff in the header files. This makes dbus foo compile. References #35.