Custom Icons (XStatuses) support in ICQ

[minstrel]

I've implemented support for custom user icons (XStatuses) in libpurple (in the same manner as it is in QIP). XStatus shows in buddy list as a picture and it's possible to select personal XStatus for particular ICQ account as well (via "Set Custom Icon..." item in account's menu). According to different mailing lists this feature is highly desirable by many users (http://developer.pidgin.im/ticket/766) so I'm looking forward to get it included into Pidgin. Extract icons to to $PIDGIN_DEV_ROOT/pidgin-<version>/pidgin/pixmaps/emblems/16

[minstrel]

patch

[minstrel]

icons

[MarkDoliner]

This looks pretty good to me. I'm a little concerned that you keep track of which icon the person is using by storing the offset into the aim_custom_icons array. Would it be possible to store the filename, instead? Or, the part of the filename without the underscore? So, "shopping," for example?

And the filenames... is there any reason they start with an underscore? It seems like it would be much more descriptive to call them "xstatus_shopping.png" or something.

[minstrel]

Well, it seems to me that it's better to store the offset than the filename. We might need to retrieve a string status description or GUID or whatever else for the certian status in the future. If we store just the file name it would be hard to do... I've changed the filenames to xstatus_xxx.png. There was no reason for them to start witn an underscore. Patch and icons are attached.

[minstrel]

patch with filenames changed

[minstrel]

icons with filenames changed

[r-wolf]

Somebody's contact X-status change is displayed only after my reconnect. Contacts without X-status are displayed as "Thinking". X-status at chat window changes to "Thinking" spontaneously.

[r-wolf]

When main status is different from "Online", then X-status is not displayed.
It would be good to see X-status comment strings somewhere at the roster.

[minstrel]

Replying to r-wolf:

Somebody's contact X-status change is displayed only after my reconnect. Contacts without X-status are displayed as "Thinking". X-status at chat window changes to "Thinking" spontaneously.

I've fixed the issue with spontaneous "Thinking" X-Status. Attaching new patch.

[minstrel]

fixed bug with spontaneous "Thinking" X-Status

[Coder_ak]

Perfect! How about X-Status text? Read and write my own?

[minstrel]

well, i would definitely like to help with that but only after i see this patch applied to one of the future versions. i want to be sure i'm not just wasting my time which is very limited...

[Robby]

cc
kthxbai

[NightFox]

I've written an X-Status text support feature to this patch. I can give that patch, but only if I'll be sure it will go to CVS.

[minstrel]

lol I had submitted my patch about 4 months ago but it haven't even been scheduled yet... The users keep asking me to make my custom builds with status icons after every new release. but who cares...

[NightFox]

Actually that's very sad :(

[Sim-on]

Is this one different from the patch in #766 ?
I would rather close this ticket to have one ticket and one patch ?! Maybe you can compare and merge these two patches ?

[petr.odut]

NightFox?: Can you please provide us your patch for Xstatus text? Many people would appreciate this! Thanks!

[NightFox]

Custom icons with text support patch, based on minstrel's patch. Including icons.

[NightFox]

I've added an attachment of my patch, which is based on minstrel's. Patch containing support of custom icons(X-Statues) with text support, text for your own x-status used from current status note. Manual "Get X-Status" button is working too. Some extra statuses such as "Depression", "At Work", "At Home" etc added too. Patch is for version 2.4.0.

[ilovemistakes]

oops again :(

to minstrel, sorry, but eidam655 said that he had "googled or smth" this patch, and i've never said that this is my patch, i've only slightly modified it. i only tried to make a temporary solution :) anyway, ticket closed.

to Mark Doliner, i've warned that code is dirty. it was temporary and based on minstrel's (now i know the owner) patch. and i'm only user, not a programmer :) thanks for notes, memleak shocked me

to minstrel and NightFox, you guys have done really good job, thanks! :)

so, may i post a patch based on NightFox's patch that works on 2.4.1? or may be it would be more polite to leave it on my hdd? :)

regards, Alexey

[MarkDoliner]

(I left these comments on ticket #766, but I should have left them here, so I'll copy/paste.) I really don't have any time to look at this in detail, but I glanced through customicons4.patch:

• Why do the icon file names start with an underscore?
• Where did the icons come from? Did someone make them?
• Please don't use // style comments. Only /* */
• Why does purple_request_field_list_get_pixbuf() return a boolean? Based on the name shouldn't it return a pixbuf?
• Maybe I'm missing something, but doesn't something need to free PurpleRequestField??->u.list.icons and PurpleRequestField??->u.list.icon_data? And where does PurpleRequestField??->u.list.icon_data get initialized? Is that hash table even used?
• In gtkrequest.c, "if(icon == TRUE)" should be "if (icon)"
• In family_locate.c, "if(customicon_found == FALSE)" should be "if (!customicon_found)"
• There's also a little stray whitespace on some blank lines in family_locate.c
• Could the parameter "no" for the aim_get_custom_icon functions be changed to maybe "n"? Or "number"?

[MarkDoliner]

Another question:

• Is it possible to unset the icon for yourself?

[ilovemistakes]

Replying to MarkDoliner:

* Where did the icons come from? Did someone make them?

afair, same icons are used in QIP.

* Why does purple_request_field_list_get_pixbuf() return a boolean? Based on the name shouldn't it return a pixbuf?

yes, i should name it as "get_iconed" or smth.

* Maybe I'm missing something, but doesn't something need to free PurpleRequestField??->u.list.icons and PurpleRequestField??->u.list.icon_data? And where does PurpleRequestField??->u.list.icon_data get initialized?

omg, that's my fault, you're right.

Is that hash table even used?

no, it isn't.

* Is it possible to unset the icon for yourself?

yes, there is "None" item in "Set custom icon" dialog.
no answer on other questions.
btw, i think you should forget about "patch modifications" from #766. we have another, more featured now :)

regards, Alexey

[Sim-on]

* Where did the icons come from? Did someone make them?

afair, same icons are used in QIP.

It would be nice to have some who match to other pidgin-smileys/status... hbons? :P

[minstrel]

i'll reply only to the questions which concern my patch:

* Is it possible to unset the icon for yourself?

yes. i've implemented that in my original patch.

* Why do the icon file names start with an underscore?

they do not (see the latest patch)

* Where did the icons come from? Did someone make them?

they are taken from QIP and should be replaced with another icons... sorry, i'm not a designer. that might be a good opportunity for some volunteer :)

* Please don't use // style comments. Only /* */

Sorry, i wasn't aware of it. That doesn't seem to be a big issue anyway.

* Could the parameter "no" for the aim_get_custom_icon functions be changed to maybe "n"? Or "number"?

sure. "number" seems ok to me. The same applies to: aim_get_custom_icon_filename(gint32 no) aim_get_custom_icon_descriptivename(gint32 no) aim_get_custom_icon_data(gint32 no) and that's not a big issue as well.

i won't make another patch to fix these small issues since NightFox? has the latest stuff right now. so go ahead, dude :)

[petr.odut]

The icons are from original ICQ client and I guess, they are under copyright. Some sort of tango-based icons would be definitely cool.

[NightFox]

I've seen X-Status icons in Kopete, maybe they're under GPL...

[simbiot]

Greets! There are a lot of x-status icons for miranda. http://addons.miranda-im.org/index.php?action=display&id=35 They are basically under "Freeware" licence. What do you think?

[eidam655]

so... what's up?

big halo around duplicating the ticket, blaming us for something we didn't do, and sudenly the development stops? :)

nice.

[lman]

Could someone make a version for pidgin 2.4.1, please?

[NightFox]

hmm...why I should ?.. I can make, but... Will this patch will be applied to next release ?

[eidam655]

carrierist! :D

[lman]

Replying to NightFox:

hmm...why I should ?.. I can make, but... Will this patch will be applied to next release ?

all right, than don't. Is there any chance that you could make it less hidden in menus? Or just show somewhere the current xStatus state icon? Or integrate the xstatus chooser into the menus instead of showing another window. Thanks in advance

[lman]

BTW, there is a patched version of pidgin: funpidgin. http://funpidgin.sourceforge.net maybe they will apply this patch to next release ;)

[resiak]

NightFox?'s patch against 2.4.0, extracted from the tarball so we can examine it in trac.

[resiak]

Some remarks on a brief review of NightFox's patch:

• There's no point in adding commented-out calls to purple_debug_*. Either don't add them, or don't comment them out.
• Please don't use // for comments; it's not supported in C89. Instead, use /* */.
• A whole bunch of calls to g_free, and return statements, have been commented out. This really can't be kosher.

[petr.odut]

Can you please write a command to patch pidgin? (something like:) patch -p1 < custom_icons4.patch but I have no idea about -pNUM switch :-\.

Is there any difference between version 2.4.0 and 2.4.1, which make patch incompatible? Is there anybody, who is able to port improvements from ticket #766 patch?

Thanks a lot for your work!

[rlaager]

NightFox?: I would encourage you to drop into #pidgin on irc.freenode.net if you have questions about this patch. If you address the problems from resiak's comment, you'll be a lot closer to getting this accepted. You should remove any unnecessary code from the patch; there are currently a couple chunks of commented-out code. There are also a few unnecessary whitespace changes. A good practice for patch submission is to read the diff itself before you send it in.

[rlaager]

There are comments like this in the patch that I don't understand: /* 6 + 4 = 10 + 8

What are those numbers for?

[rlaager]

I also see changes of this type: - if (state & AIM_ICQ_STATE_CHAT) + if (state == AIM_ICQ_STATE_CHAT)

Why is that being done? (I'm not saying it's wrong. I'm saying I don't understand this codebase, so I'm asking why.)

[minstrel]

You guys would better start from checking-in the original patch: custom_icons.3.patch I've submitted it 4!!! months ago and to me it seems to be completely straight forward. I can't understand why you don't encourage people to write patches, improve pidgin etc, but do the opposite...

[NightFox]

because that-> if (state & AIM_ICQ_STATE_CHAT) is illegal

[elb]

Replying to NightFox:

because that-> if (state & AIM_ICQ_STATE_CHAT) is illegal

Why is it illegal? It's simply a bit check for the AIM_ICQ_STATE_CHAT bit.

[elb]

Replying to minstrel:

You guys would better start from checking-in the original patch: custom_icons.3.patch I've submitted it 4!!! months ago and to me it seems to be completely straight forward. I can't understand why you don't encourage people to write patches, improve pidgin etc, but do the opposite...

I'm sorry you feel that anyone is "doing the opposite". Please do not confuse lack of time for active discouragement. The only reason this has not been dealt with before now is that the appropriate people did not have the time to do so. There is no conspiracy theory here to keep your patch from proceeding. :-)

This patch (from minstrel) introduces some strings which should be translated, and unfortunately we are currently in string freeze; it looks like it can go in as soon as 2.4.2 is released with minimal changes. (The spurious introduction of curpos, some unnecessary whitespace changes, correct the typo of "Engineering", fix some occurrences of //, reconcile some consts.)

The patch from NightFox? has some more serious issues and will require further review.

In the future, if a patch which is complete and largely appropriate for inclusion is languishing in the tracker, feel free to come make some noise in #pidgin or devel@…. Once a patch has been claimed by a developer on the tracker, it often gets little attention from other developers (as do unclaimed patches which are in an area "belonging" to a particular developer); in consequence, if that developer gets busy or is unavailable for some reason, it can take a while to get it merged. A friendly poke is all it might take to get it moving again, there's no need to feel like you're being ignored!

[sadrul]

It looks like custom_icons.3.patch and xstatus-patch-pidgin-2.4.0.patch are the most updated versions of the patch (the former looks cleaner). Is either of them in a state to be applied to .next.minor for 2.5.0?

[Sim-on]

first we need an iconset!!! ;) hbons, did you read this? ;)

[hbons]

What kind of icons? I'm sorry, I'm not really following. It's been a while since I last used ICQ (> 10 years)

[Sim-on]

Replying to hbons:

What kind of icons? I'm sorry, I'm not really following. It's been a while since I last used ICQ (> 10 years)

have a look in custom_user_icons.tar.2.gz. This patch will include different status icons for e.g. gaming, coffee, eating,...

[hbons]

Ok. So in ICQ the status icon is replaced by those special icons? If it is, I think it's a better idea to have them as emblems tough. To keep the buddy status system clean.

[petr.odut]

it is done that way, please try this patch before commenting ;-)

[Sim-on]

hm in standard-ICQ these icons are replacing the status-icon but ok ;)

[Coder_ak]

Patched against version 2.4.2 some rejects but compiles without errors. No x-status text input field and no text in buddies profile

[Sim-on]

something new on this issue? i would like to see this feature in 2.5.0 ;) :P

[eidam655]

any news?

does this work with 2.4.3?

can we finally get/set custom status messages?

[bob007]

NightFox?'s "old" patch, recreated for pidgin 2.4.3 because his patch doesn't works with 2.4.3 any longer

[salieff]

Hi! I got last patch, and slightly change it 1.) It has 3 segfaultes when parse malformed x-status autoreply - fixed 2.) It don't change pidgin/pixmaps/Makefile.in, only Makefile.am - fixed 3.) Added x-messages autorequest when user with xtraz capability goes online

[Mentis]

salieff, I try your patch and its goood =) Thaks! But i found 1 bug in it:

If my friend (he use QIP) fill only field2, i cant fetch his xstatus message. See this screenshots:

What my frend do: http://img397.imageshack.us/img397/4551/10182705bd9.jpg What i see: http://img359.imageshack.us/img359/8162/screenshottr3.png

But if he fill field1 also, everything works fine: http://img355.imageshack.us/img355/4039/screenshot1oe8.png

[sadrul]

I can start committing the patch(es) (after some modification, since some of the raised concerns are not addressed yet) to some branch. But I don't have any ICQ buddies, so I won't be able to test any of these. If there's someone with time and will to build from a different branch in mtn and test the changes, let me know. (Sounds like Sim-on uses ICQ, do you also build from mtn?)

[Mentis]

Replying to sadrul:

I can start committing the patch(es) (after some modification, since some of the raised concerns are not addressed yet) to some branch. But I don't have any ICQ buddies, so I won't be able to test any of these. If there's someone with time and will to build from a different branch in mtn and test the changes, let me know. (Sounds like Sim-on uses ICQ, do you also build from mtn?)

I can gladly help if you explain me where i can grab sources.

[nops]

Patch [xstatus-patch-pidgin-2.4.3_1.patch] for 2.5.0 sources (+deleted some unusefull comments and blank lines).

[Sim-on]

Replying to sadrul:

(Sounds like Sim-on uses ICQ, do you also build from mtn?)

You can commit these patches :) i'm on windows but i once built from source so this won't be a problem :) and i have enought icq-friends for testing :)

[h3llfire]

custom status icons in tango style, freeware, created by N3fr0n

[nops]

Patch for 2.5.1 sources

[nops]

The xstatus-patch-pidgin-2.5.1.patch is modified xstatus-patch-pidgin-2.5.0.patch for 2.5.1 source code. Added lost code from #776 custom_icons4.patch (add icons in x-status icon dialog, engeneering -> engineering) and small changes for some recommendation from MarkDoliner.

[eidam655]

hello,

i'm very glad of this patch working :)

i just have a question - how does the "Get X-Status msg" option in a buddy's context menu work?

because, some status x-status messages are loaded automatically and are shown, but with some buddies with the x-status set, there is no apparent status message.

so, this raises the question: why is that option there?

and another question: how do i set MY own x-status message? is there any possibility that the x-status message can be set from the global status setter?

thank you for clearing this to me :)

[nops]

Replying to eidam655:

so, this raises the question: why is that option there?

It was added in early patch, that has no autofetch function. Now, this no longer needed. But autofetch function need modification - on very big contact list fetch packets may overflow channel, and server may drop connection.

and another question: how do i set MY own x-status message? is there any possibility that the x-status message can be set from the global status setter?

Yes, this is set from global status message.

[eidam655]

Replying to nops:

Replying to eidam655:

so, this raises the question: why is that option there?

It was added in early patch, that has no autofetch function. Now, this no longer needed. But autofetch function need modification - on very big contact list fetch packets may overflow channel, and server may drop connection.

Ah, I already noticed that - when many ICQ buddies are connected, i connect to the server, load the buddy list, and then i get the message "Connection closed by peer." at least i think it's because of that.

and another question: how do i set MY own x-status message? is there any possibility that the x-status message can be set from the global status setter?

Yes, this is set from global status message.

so... why can't i see it, when i have *me* in my contact list, ans after setting a status message, it appears on my MSN and Jabber accounts, but not on the ICQ - even after trying "Get X-Status message" several times.

[Gromescu]

I have a strange bug with this patch - I can't read n/a, dnd and occupied statuses from all of my buddies except those who use qip. They are shown as available.

Look at Test buddy logged in from qip

http://pic.ipicture.ru/uploads/081028/b55mGJ64kD.png

and from miranda

http://pic.ipicture.ru/uploads/081028/anUddCV2b6.png

Another is with users with away status when custom icon is not set

http://pic.ipicture.ru/uploads/081028/cf4cvPlJUF.png

If a buddy specifies icon it displays as usual

http://pic.ipicture.ru/uploads/081028/tBL1saStGb.png

This bug is also with qip users.

[nops]

Patch for 2.5.2 sources

[nops]

Changes in xstatus-patch-pidgin-2.5.2.patch:

• based on xstatus-patch-pidgin-2.5.1.patch;
• X-status requests is queued (packets do not overflow channel);
• added parse icqmood, method transmit icons in some client, e.g. R&Q;
• code refactoring.

[Gromescu]

I had two rejects applying this patch

***************
*** 5826,5833 ****
  		else
  			ret = g_strdup(_("Offline"));
  	}
- 	else
  	{
  		message = purple_status_get_attr_string(status, "message");
  		if (message != NULL)
  		{
--- 5922,5940 ----
  		else
  			ret = g_strdup(_("Offline"));
  	}
+ 	else if (purple_status_is_available(status) && !strcmp(id, OSCAR_STATUS_ID_AVAILABLE))
+ 	{
+ 		/* Available */
+ 		message = purple_status_get_attr_string(status, "message");
+ 		if (message != NULL)
+ 		{
+ 			ret = g_strdup(message);
+ 			purple_util_chrreplace(ret, '\n', ' ');
+ 		}
+ 	}
+ 	else if (!purple_status_is_available(status) && !strcmp(id, OSCAR_STATUS_ID_AWAY))
  	{
+ 		/* Away */
  		message = purple_status_get_attr_string(status, "message");
  		if (message != NULL)
  		{
***************
*** 5840,5847 ****
  			g_free(tmp2);
  		}
  		else
- 			ret = g_strdup(purple_status_get_name(status));
  	}
  	return ret;
  }
  
--- 5947,5959 ----
  			g_free(tmp2);
  		}
  		else
+ 		{
+ 			ret = g_strdup(_("Away"));
+ 		}
  	}
+ 	else
+ 		ret = g_strdup(purple_status_get_name(status));
+ 
  	return ret;
  }
  

Edited manually. It seems to be working.

The problem with away status not appears now. But pidgin still does not read na, dnd, occupied statuses from miranda

[NightFox]

Sure it shouldn't

[Gromescu]

Pidgin hungs up when I press get aim info

[rekkanoryo]

hbons: I am committing this patch to a side branch in mtn for some improvement work before it hits im.pidgin.pidgin. As mentioned above, we do need some artwork, specifically for the following emblems in the patch:

• emblems/16/xstatus_angry.png
• emblems/16/xstatus_bathing.png
• emblems/16/xstatus_beer.png
• emblems/16/xstatus_busy.png
• emblems/16/xstatus_cinema.png
• emblems/16/xstatus_coffee.png
• emblems/16/xstatus_crap.png
• emblems/16/xstatus_crapping.png
• emblems/16/xstatus_eating.png
• emblems/16/xstatus_engineering.png
• emblems/16/xstatus_friends.png
• emblems/16/xstatus_fun.png
• emblems/16/xstatus_gaming.png
• emblems/16/xstatus_google.png
• emblems/16/xstatus_heart.png
• emblems/16/xstatus_internet.png
• emblems/16/xstatus_iron.png
• emblems/16/xstatus_mobile.png
• emblems/16/xstatus_music.png
• emblems/16/xstatus_party.png
• emblems/16/xstatus_pda.png
• emblems/16/xstatus_phone.png
• emblems/16/xstatus_question.png
• emblems/16/xstatus_shopping.png
• emblems/16/xstatus_sick.png
• emblems/16/xstatus_sleeping.png
• emblems/16/xstatus_studying.png
• emblems/16/xstatus_surfing.png
• emblems/16/xstatus_thinking.png
• emblems/16/xstatus_tired.png
• emblems/16/xstatus_tv.png
• emblems/16/xstatus_typing.png
• emblems/16/xstatus_writing.png
• emblems/16/xstatus_zzz.png

If you can do any of these, feel free to send them directly to me (rekkanoryo@…) and I'll add them to my tree.

Of course, there is a zip file attached to this ticket with "freeware" icons per the description; if these are suitable for our inclusion that will work too, but their license should be GPL if we're to include them.

[rekkanoryo]

A comment will hit this ticket shortly because I committed this to a branch in the monotone repository. I need names to credit the contributors listed in that comment, preferably real names. Currently what I have committed compiles, but I haven't tested it.

[rekkanoryo@…]

(In [1431506710bed6b8f0c837b670ee314b1692990e]):
This patch comes from the combined work of contributors minstrel, NightFox?, bob007, salieff, and nops (these are their trac usernames). I have made some minor tweaks to the patch, but these shouldn't be a problem. This patch needs some TLC before we can merge it anywhere else; it adds API so it must hit im.pidgin.pidgin.next.minor before hitting im.pidgin.pidgin. Refs #4508.

[NightFox]

I can say my real name if needed :)

[N3fr0n]

Someone on µTorrent forum contacted me about using my xstatus icons in Pidgin. I’d be happy to participate, but: 1. I need to be sure what to do with licence. (They’re my work inspired by Tango guidelines, so is this suitable: http://creativecommons.org/licenses/by-sa/2.5/?) 2. I don’t have all the icons and the last few (starting from typing) have slightly different metaphors from Miranda descriptions. What will we do about this?

By the way, here (http://addons.miranda-im.org/files/screenshot/81-1-1209928248-preview.png) is a screenshot. Just for quick image, some of the icons are outdated (the actual version is improved).

[rekkanoryo]

Replying to N3fr0n:

Someone on µTorrent forum contacted me about using my xstatus icons in Pidgin. I’d be happy to participate, but: 1. I need to be sure what to do with licence. (They’re my work inspired by Tango guidelines, so is this suitable: http://creativecommons.org/licenses/by-sa/2.5/?) 2. I don’t have all the icons and the last few (starting from typing) have slightly different metaphors from Miranda descriptions. What will we do about this?

Pidgin is a GPL version 2 application, which makes us license-incompatible with the CC Attribution-Share Alike license. If you're fine with GPLv2, that would simplify matters significantly. If you prefer, you could also have it be the redistributor's choice of the CC license or the GPL (obviously Pidgin would choose the GPL option).

As for the metaphor differences, I'm not sure I understand what you mean. If you could clarify that, it would be helpful.

By the way, here (http://addons.miranda-im.org/files/screenshot/81-1-1209928248-preview.png) is a screenshot. Just for quick image, some of the icons are outdated (the actual version is improved).

Those look fine to me, but I'd like hbons' opinion on them.

[rekkanoryo]

Replying to NightFox:

I can say my real name if needed :)

Yes, I need you, minstrel, bob007, salieff, and nops all to give me your real names. If you prefer to do so privately, email me. My address is rekkanoryo@…. Make sure to indicate your trac username so I know who is who :)

If N3fr0n agrees to a licensing option that works for us both with the icons, I'll need his/her real name as well.

[rekkanoryo]

It appears that there is a flaw in the patch--ICQ6 users can't see the icon specified by Pidgin. It works fine when testing Pidgin to Pidgin though. As I'm not an expert in ICQ, I'd appreciate any help fixing this.

[N3fr0n]

Yes, I agree with the GPLv2 licence. One problem seems to be solved.

And the metaphors – it is quite difficult matter. Every client has the different icons, because they have no defined meanings on ICQ. From the standart icons (which can be found in ICQ6) there could be just one doubt – video camera (official) replaced by photo camera (like in Miranda). In unnoficial additional icons it is not so clear. For example the zzz status is (in some clients) pictured as cannabis leaf, the iron status is even more uncertain. No-one knows if it’s an iron or some TV logo.

Beside this, ICQ6 will not show any status when you have one of the additional icons set, some clients support only some icons.

In my opinion it would be good to keep just some of the icons, which we can be at least particulary sure of.

[N3fr0n]

The new version of xstatus icons (some alternative icons are attached). GPLv2

[hbons]

N3fr0n, I like these!

I would like the smilies to be the same style as found in Pidgin, so will need to adjust them (was planning on doing a full 16x16px set anyway). But we can definitely use the other activities.

Do you have source files available?

btw, the surfing one is rocking at that size! :)

[N3fr0n]

Smileys for adjusting.

[N3fr0n]

Smiley which was wrong in the previous upload.

[rlaager]

N3fr0n, we're actually a "GPL version 2 or any later version" app. Are you okay with that licensing?

Regarding the identification of icons, what specifically is put on the wire? Is it the "xstatus_filename" or the binary data? If it's the data rather than the filename, "engeneering" is spelled wrong. If it's the filename, well, there's not much we can do about that.

This also gets into the ambiguities... If the protocol-level string is "xstatus_iron", I'd say we should ship an icon of an iron. The flip side of this, I suppose, is (and this is not rhetorical, if you know the answer, that'll help a lot), "Who came up with these names?" For example, if some third party client introduced "zzz" as smoking pot, then we should honor that (or not use it at all). (If they didn't, then "zzz" really should be sleeping, but we already have that.) I don't see how "cooking" is a trash can or "mobile" is smoking either.

[N3fr0n]

Yes, I’m okay with that licensing. I’m sorry for the mispellings, I also made a mistake in question (I wrote questiong). Will someone who commits these icons fix that? I just tried to put the icon names in form like the previous were. The iron icon… in Miranda this was imaged as the Pro Sieben logo, the original ICQ (?) icon didn’t resemble iron either. I think that just someone thought it looks like an iron. Regarding the others, I’m not sure. "Zzz" was a dark-haired man with a blue bubble next to his eye and a text "zzz" (see in screenshot above) so I supposed a crying smiley would be good. Frankly, I’m not sure about this.

[rekkanoryo]

This functionality, with some significant revision and expansion to include XMPP PEP Mood status attributes, should appear in Pidgin 2.6.0.

[rlaager]

For the record, this branch hasn't been merged yet (unless someone else did it, which I hope they didn't). It needs probably another night's worth of work from me, which may or may not happen this week. Basically, I just need to finish up porting the GUI into Pidgin w/o the request API changes and make it work for XMPP as well.

[jochenito83]

I successfully applied this patch to my pidgin 2.5.2. I was wondering if someone could adjust it to fit 2.5.3 or if I could do this myself.

The only thing that was not working right for me was the icons that were not displayed at all: neither in the buddy list nor in the XStatus menu.

Is there already a release date for 2.6.0 if this feature is supposed to be included?

[rekkanoryo]

This patch is already applied to a branch that will be merged into what will become Pidgin 2.6.0 when Richard has time to get back to working on the changes he wants to see. There's really no point in "updating" the patch since it's already been accepted.

[jochenito83]

OK, cool. Then I'll be waiting for 2.6.0 to be released. Thanks for the info! :)

[petr.odut]

still doesn't see this feature in 2.6.0 milestone, will you add it later?

Using Pidgin 2.6.0devel from http://ppa.launchpad.net/frasten/ppa/ubuntu

[ehpc]

Here is modified patch for pidgin 2.5.5: xstatus-patch-pidgin-2.5.5.patch, based on xstatus-patch-pidgin-2.5.2.patch.

[ehpc]

pidgin 2.5.5 patch based on 2.5.2

[rekkanoryo]

I'm pushing this back to 2.7.0 because it looks like the UI work we want to put this in im.pidgin.pidgin won't be done in time. We have every intention of getting this support added and released; it's just going to take a bit longer.

[Halan]

Whats the status on this project?

[rekkanoryo]

Just as an update, this branch has been merged back to im.pidgin.pidgin and will be included in the 2.7.0 release. Unless security issues necessitate the release of a 2.6.7 in the mean time, 2.7.0 should be our next release. I'm not going to close this ticket as fixed yet, however, as I believe Marcus has a few more UI items he feels needs worked out before we call it release-ready.

[rekkanoryo]

For the record, I never received real names for bob007, salieff, and nops. For proper attribution, I need to know names to credit these users.

[malu@…]

(In [68061a38b746a64fe929374f659fb619c0824d95]):
ChangeLog mood support stuff Closes #4508