Ticket #4757 (closed patch: fixed)

Opened 4 years ago

Last modified 4 years ago

QQ contact alias and group setting reverts to default on restart

Reported by: rchi Owned by: csyfek
Milestone: 2.5.0 Component: QQ
Version: 2.3.1 Keywords: QQ alias
Cc:

Description

System: WinXP, Pidgin 2.3.1.

If changing a QQ contact alias, or merge QQ contact into an existing contact, the change is reset back to default when restarting pigdin. I looked into the blist.xml file, the updated setting were written correctly. But the setting gets clobbed with the default the next time pigdin connects to QQ again.

Steps to reproduce:

1. right click on QQ contact, select "Alias" 2. change alias to something else. 3. exit pigdin 4. look into blist.xml, setting written correctly. 5. restart pigdin, changed alias is gone.

Similarly for contact group setting.

This does not happen with MSN or Yahoo contacts. Thanks.

Attachments

99_qq_group_name.patch (4.1 kB) - added by manphiz 4 years ago.
This patch also solves the (NULL) QQ group name regression.

Change History

follow-up: ↓ 2   Changed 4 years ago by manphiz

This is due to the protocol change in QQ. Dino <linux@…> has provided a patch on bbs.linuxsir.org, though still a crude one. I'm attaching it as a reference, and hope someone refine it and commit it to trunk.

Changed 4 years ago by manphiz

This patch also solves the (NULL) QQ group name regression.

in reply to: ↑ 1   Changed 4 years ago by Sim-on

  • type changed from defect to patch

Replying to manphiz:

This patch also solves the (NULL) QQ group name regression.

-> #5077

  Changed 4 years ago by manphiz

Any reason this patch is still not applied or reviewed? The problem has been here for about 3 month and persisted on 2 major releases, and IMHO the fix is not big.

  Changed 4 years ago by deryni

My guess as to why the patch has yet been applied is that the const and debug message change in the first chunk seem out of place and that we don't have anyone who actively uses QQ let alone understands the code well enough to really judge whether this makes sense easily.

  Changed 4 years ago by manphiz

I agree that the patch is rather crude. Is there any criterion one can follow to refine it? I'd like to help.

  Changed 4 years ago by deryni

There has been some recent discussion about bringing the openQ people in to maintain the pidgin QQ protocol, in which case they would want to look at and apply this patch. Assuming that happens in the next little bit I would hope this patch would get evaluated and either committed or commented on by them.

  Changed 4 years ago by rlaager

  • owner changed from seanegan to csyfek

follow-up: ↓ 9   Changed 4 years ago by csyfek

  • keywords QQ alias added
  • status changed from new to assigned

Thanks manphiz! How are you going? :D

in reply to: ↑ 8   Changed 4 years ago by manphiz

Replying to csyfek:

Thanks manphiz! How are you going? :D

Thanks a lot csyfek! It seems your patches makes QQ support in pidgin MUCH BETTER! As in version 2.4.3 this bug doesn't exist anymore, feel free to close :D

  Changed 4 years ago by Sim-on

  • status changed from assigned to closed
  • resolution set to fixed

  Changed 4 years ago by Robby

Might want to add the milestone, for reference. :)

  Changed 4 years ago by csyfek

  • milestone set to 2.5.0

yes, Robby. :)

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!