Big Custom smileys annoying in gtkconv

[salinasv]

Big custom smileys are just annoying because it takes all my gtkconv window to show.

This can be avoided with a GdkPixbufLoader?-fu

[salinasv]

Fix the incoming custom emoticon size

[sadrul@…]

(In [6e7c4dd26da75349ba06490409bce8a1ccfbcb2a]):
Patch from Masca to restrict the size of incoming custom smileys to a maximum of 96 pixels on either side. Closes #5231.

[sadrul]

I changed the max size to 96 (is it worth the effort to make it a theme setting?), and changed the resize code to make sure the wide smileys also aren't wider than the max size.

[Robby]

This goes into 2.4.2?

[sadrul]

No. Large parts of the custom smileys have been changed for the new Smiley API, which will be available in 2.5.0 (planned to be released after 2.4.2). This patch will also be available with that version.

[Robby]

Oh, I see. Wouldn't it make sense then to assign it to a milestone named "2.5.0"?

[salinasv]

Replying to sadrul:

I changed the max size to 96 (is it worth the effort to make it a theme setting?), and changed the resize code to make sure the wide smileys also aren't wider than the max size.

I don't see any problem with making a pref for this. Sounds like a good idea.

[Xinef]

Sorry for digging up an old topic, but this is probably better than creating a ticket. I was actually looking for a way to disable this feature, as I want to see custom smilies I receive full size (or at least bigger than 96px). Was the pref for this ever implemented?

[deryni]

Not that I can see anywhere.

[Xinef]

Adds Conversations prefs for resizing or not incoming custom smileys and to which size

[Xinef]

Attached a patch that adds the corresponding preferences.

[salinasv]

Replying to Xinef:

Attached a patch that adds the corresponding preferences.

Applied, Please give us your name to give you credit.

[masca@…]

(In [68ec69a92f608fa91e453499f83908b79b96d047]):
Make the max size of incoming smileys a pref instead of harcoding it. Patch from Xinef (with small modifications) Refs #5231

[Xinef]

Thanks for taking the time to integrate it properly (now that I see the 'modified' version, I can see my patch could have used some testing...) Quentin Brandon

[salinasv]

Done, Thank you.