Ticket #5275 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

Allow clicking on the buddy icon in the infopane to toggle between the normal size and full size.

Reported by: deryni Owned by: deryni
Milestone: Patches welcome Component: unclassified
Version: 2.4.0 Keywords:
Cc:

Description

I'm filing this ticket as a simpler version of the requests in #2478 and #3135.

Attachments

gtkconv.diff (3.9 kB) - added by chrono 2 years ago.
gtkconv.2.diff (4.6 kB) - added by chrono 2 years ago.

Change History

Changed 2 years ago by alexef

If somebody could guide me, I would like to write this patch. I know C, but don't have any GTK+ experience. My contact: alex at rosedu dot org

Changed 2 years ago by chrono

Changed 2 years ago by deryni

Very nice, but not quite perfect. It would probably be better, I think, to keep the scale size in the preference which would mean you don't need the ternary operator all over the place (and would let people who wanted other sizes easily do that). The other problem is that 64 pixels isn't going to be full size for a lot of icons, so we would either need to use the largest any protocol can set the icon or get the size of the icon and use that.

Given both points above I think it might make the most sense to leave the preference as a boolean (for completeness sake you probably want to _prefs_add_ the preference somewhere) and make it use the full size of the icon (whatever that might be, with a cap at some reasonably large value like 128 pixels or whatever the max most official clients show is) or 32 as appropriate.

Changed 2 years ago by chrono

Changed 2 years ago by Richter_X

I think the correct avatar resolution on YIM and MSN avatars is 96x96, and 48x48 on AIM. Which is what I'd prefer it to look, as scaling avatars makes them look rather ugly. An option for showing the IM's standard avatar size would be a good addition.

Another option for setting where the avatar goes according to user preference would also be a good idea. Personally, I like it on the lower left corner right next to where I enter text. It should probably be in its own separate patch/plugin though.

Also, how do I use these patches exactly? Do I have to compile anything?

Changed 2 years ago by deryni

  • owner changed from lschiere to deryni

Richter_X: When you say 'showing the IM's standard avatar size' I'm assuming you mean at their actual size and not at the normal or maximum size for the protocol, correct? An option for buddy icon placement is not going to happen, though a plugin could place the icon back down near the text entry area (as poor a placement as that really is). And yes, to use the patch as it exists now you would need to download the pidgin source and the patch, then run the patch command to apply the patch and compile pidgin. It is my intention to apply this patch (modified slightly probably) to pidgin sometime soon so it might just make sense to wait a little while for it to be accepted.

chrono: Nice changes, still not exactly perfect but my feelings now are more on style then on function. I'll probably see if I can tweak it myself rather than trying to explain my issues (since I'm not sure I can).

Changed 2 years ago by Sim-on

  • status changed from new to closed
  • resolution set to fixed

sadrul applied this feature for 2.4.2... (see #5705).

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!