First Item in mail-notification dialog is not selected / no visible focus

[private_lock]

When the Mail Notification-Dialog pops up, in previous versions of Pidgin the first entry was selected, so I just had a single click on the lower right button to launch my webmail interface. Now, I first have to click the item and then the button.

Moreover, there is no visible indication, where the keyboard focus is, when the dialog comes up. pressing Enter "magically" does the right thing, but it's not shown. And I didn't wait for several emails to check, what it does, when there are more items to select.

This is a yahoo-eMail-account, if that makes any difference. Pidgin 2.4.1 on Kubuntu Hardy (came with adept on the version upgrade)

[diocles]

Browse mode, and select first element if not selected

[diocles]

The above patch was just a quick hack, and hasn't been tested on anything other than an MSN account. It hasn't been tested with situations where more than one row appears.

Turning on the 'browse' selection mode was probably unnecessary - in my opinion the selection_changed callback could be removed in favour of browse mode.

[rekkanoryo]

Casey, can you take a look at this patch too?

[QuLogic]

This looks mostly fine to me. Please provide a name and email address for our COPYRIGHT file.

The one thing I would change is using a GtkTreeIter instead of a path, because using gtk_tree_model_iter_first, you can get the first element and check if it exists in one call, instead of counting the number of children + getting the first element.

[diocles]

Tim Retout <tim@…>

I'm amazed the patch still applies. :)

[QuLogic]

Well, it did require a small bit of tweaking.

[tim@…]

(In [450dfc46a4682fc424c205fb56699f20e9836386]):
Select the first item in the mail-notification dialog. Also, change the treeview to "Browse" mode.

I changed the patch to use a GtkTreeIter instead of a GtkTreePath, which is simpler. Also, remove some redundant function calls due to the newly introduced variables.

Fixes #5789.

[Robby]

Replying to diocles:

Tim Retout <tim@…> I'm amazed the patch still applies. :)

I was surprised you replied. ;)