Ticket #5886 (new patch)

Opened 2 years ago

Last modified 15 months ago

SIP/SIMPLE improvements from Chris Brody

Reported by: MarkDoliner Owned by: rlaager
Milestone: Patches Needing Review Component: SIMPLE
Version: 2.4.2 Keywords:
Cc:

Description

This patch is from Chris Brody (cbrody att stanfordalumni dott org). The patch was made against 2.0.0 beta 7. "In general, most of these changes are not elegant, to say the least."

  1. Abbreviated headers: not elegant, but worked with the Siemens switch. They had options: to send abbreviated headers and accept either normal or abbreviated headers, or only send & accept abbreviated headers.
  2. Authentication fixes: using a bogus cnonce for Digest auth, use auth->digest_session_key, elementary support for QOP & opaque parameters, support for nextnonce parameter, using Authorization & Proxy-Authorization with auth_uri in a number of messages, support for header Authentication-Info with nextnonce, small retries fix.
  3. Experimental PIDFs-I believe I did not have real success and you can ignore them.
  4. Adding "," for multiple Accept headers in process_incoming_subscribe
  5. Hard-coded change to resend_timeout, should be configured.
  6. Commented out simple_typing callback for message-caused problems with our system-should be configured.

Attachments

simple.patch (18.8 kB) - added by MarkDoliner 2 years ago.

Change History

Changed 2 years ago by MarkDoliner

Changed 2 years ago by zinid

I found that Pidgin doesn't include "opaque" field in the "Authorization response" to "WWW-Authenticate request" (this breaks rules of RFC 2617). I'm just wondering does this patch solves the problem? Currently I can't login to YXA with Pidgin due to this issue.

Changed 22 months ago by rekkanoryo

Any particular reason this patch hasn't been applied yet?

Changed 22 months ago by MarkDoliner

I don't know anything about SIMPLE or this patch. I think the guy just emailed it to me and wanted me to post it or something. So I don't think anyone has looked at it.

Changed 21 months ago by rekkanoryo

  • owner changed from seanegan to rlaager

I don't really know who else to assign this to, but I'm tempted to commit this on a branch, call for testing, and merge if appropriate.

Changed 15 months ago by rekkanoryo

  • milestone set to Patches Needing Review
Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!