Ticket #7180 (closed defect: fixed)

Opened 2 years ago

Last modified 19 months ago

WLM Beta buddy icons do not show

Reported by: Merkaba Owned by: khc
Milestone: 2.5.5 Component: MSN
Version: 2.5.1 Keywords: MSN, buddy icons
Cc: Dimmuxx, tomgr

Description

I recently upgraded to the latest public beta of Windows Live Messenger (Version 2009 Build 14.0.5027.908) and am unable to view buddy icons for libpurple users (Pidgin and Adium specifically). Using Pidgin I am also unable to see the buddy icons of users using the WLM beta. The latest stable version of WLM (8.5.1302.1018) can view libpurple buddy icons and vice versa

Attachments

Buddy icon.log (9.6 kB) - added by Merkaba 23 months ago.
Debug log
fix-icons.diff (3.6 kB) - added by tomgr 20 months ago.

Change History

  Changed 2 years ago by Sim-on

  • owner changed from lschiere to khc
  • component changed from unclassified to MSN

  Changed 2 years ago by Merkaba

An extra bit of info that might help is that when using MSN Pecan in Pidgin my buddy icon is then visible to them. Unfortunately my buddy icon is still not visible to users in the beta version of WLM. I'm also experiencing similar issues with random users of WLM 8.5.

This is in Pidgin 2.5.1 in Windows XP SP3 and Vista SP1.

  Changed 2 years ago by Dimmuxx

That your buddy picture doesn't show for other WLM users is a known bug in msn-pecan. That you are able to see the pictures of WLM beta users with msn-pecan is interesting though.

  Changed 2 years ago by Merkaba

I seem to be getting better results using MSN Pecan than the default MSNP15 method in Pidgin. Though after an hour or two several of my contacts buddy icons now show in Pidgin. I've added myself as a contact to a separate WLM account and using the beta I see no change in my Pidgin account's avatar when I change it in Pidgin. Should I attach a debug log?

I also see that Adium has the same issue [http://trac.adiumx.com/ticket/10411 ] though it seems to be connected to MSN Pecan.http://code.google.com/p/msn-pecan/issues/detail?id=93 My issue is connected to the MSNP15 protocol that comes as default with Pidgin though. Worryingly enough it is also not just WLM beta users that I'm having trouble with as I mentioned in my previous comment. Any ideas?

  Changed 23 months ago by QuLogic

  • status changed from new to pending

Please follow the instructions to get a debug log and attach it to this ticket.

Changed 23 months ago by Merkaba

Debug log

  Changed 23 months ago by Merkaba

  • status changed from pending to new

Attachment (Buddy icon.log) added by ticket reporter.

  Changed 23 months ago by Merkaba

Debug log added with an MSN account in Pidgin 2.5.2 with one contact using the beta version of WLM. Nether the WLM user or Pidgin user can see each others' avatars.

  Changed 20 months ago by Merkaba

Similar problem reported for users with MSN Pecan protocol plugin.

http://code.google.com/p/msn-pecan/issues/detail?id=108

  Changed 20 months ago by QuLogic

It looks like P2P stuff may have changed slightly. Perhaps related to #7294. I don't think we debug print enough to be figure this out from just user reports, though.

Changed 20 months ago by tomgr

  Changed 20 months ago by tomgr

I've attached a patch which fixes sending/receiving of buddy icons and receiving of custom emoticons from people using the wlm 9. It seems that the new version sends a flag of 0x1000020 rather than 0x20 for its buddy icon - I expect this indicates that it is animated. Also, when it requests our buddy icon the flag is set to 0x1000000 rather than 0x0 - again perhaps this indicates it can accept animated buddy icons.

In either case, treating the flags as their counterparts fixes everything!

It also seems to fix the file transfer issues of #7294 - I was able to receive a file from someone using wlm 9 fine.

  Changed 20 months ago by datallah

Ticket #8170 has been marked as a duplicate of this ticket.

  Changed 20 months ago by markuznw

@tomgr Tested the patch with both original msn and msn-pecan and it works fine. Thank you :)

  Changed 20 months ago by qulogic@…

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 2.5.5

(In [8577210d86a9a6cd448208a4ef92c42cd39200f7]):
A patch from Thomas Gibson-Robinson to fix receiving buddy icons, custom emoticons and file transfers from WLM 9. I have a feeling this should really be a bitwise test (ie, flags | 0x20 == 0x20) but I can't really find many supportive docs for FT things and I'm no expert on these MSN SLP bits.

Fixes #7180. Fixes #7294.

  Changed 20 months ago by qulogic@…

(In [27a5e4c3bf4db89f9d87c37d7043c1f4dc68ed1f]):
Report a debug warning if a SLP MSG is not processed because it has unknown flags. This should make it easier to fix problems like with WLM 9.

References #7180.

  Changed 20 months ago by datallah

Ticket #8185 has been marked as a duplicate of this ticket.

  Changed 20 months ago by felipec

tomgr: I applied your patch to msn-pecan but we prefer to set the author of the patch, including the email if possible. Can I have it?

  Changed 20 months ago by tomgr

felipec: You certainly can, it's thomas.gibsonrobinson AT gmail DOT com

  Changed 19 months ago by heartwarmer

i applied the patch to pidgin 2.5.4 source,and installed it but it didnt work, am i missing something?

follow-up: ↓ 20   Changed 19 months ago by yelo3

tomgr: you have written this patch which works really well, but it seems that also offline messages cannot be received, maybe another small tweak like this is needed?

in reply to: ↑ 19   Changed 19 months ago by tomgr

Replying to yelo3:

tomgr: you have written this patch which works really well, but it seems that also offline messages cannot be received, maybe another small tweak like this is needed?

You might want to have a look at #7901 which is about the problem you describe; it was apparently fixed for 2.5.4 and it certainly seems to be working for me. Glad the patch works for you!

  Changed 19 months ago by yelo3

No, that's not my problem. offline messages from pidgin users work well, but from the new windows live messenger are not received. to receive them I need to log in using windows live messenger, so I thought it was a problem like this and I wrote here. I think I must open a new bug

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!