Double UTF-8 encoding in oscar protocol

[xmarchello]

Sometimes Cyrillic messages in oscar protocol come UTF-8 encoded but libpurple encodes it again. This behavior usual for authorization requests.

[rekkanoryo]

The core issue here seems to me to be the same as in #5943.

Mark, can you please take a look at this one and see if the other patch covers this case too?

[xmarchello]

Replying to rekkanoryo:

The core issue here seems to me to be the same as in #5943. Mark, can you please take a look at this one and see if the other patch covers this case too?

In terms of function calls these tickets are unrelated. But it would be a great idea to introduce common mechanism to deal with UTF8 encoding/decoding and handle oscar protocol fixes there.

[nops]

The real problem in oscar.c in function purple_ssi_authrequest. Authorization request comes in UTF-8, but in this function it's convert to UTF-8 (msg -> reason). This is wrong, and this not need to be converted. Also, libpurple send authorization request in UTF-8 (family_feedbag.c function aim_ssi_sendauth).

Why it need to be converted? I think this is a mistake.

[nops]

Replying to rekkanoryo:

The core issue here seems to me to be the same as in #5943.

No, this ticket is not related.

[darkrain42]

Replying to nops:

The real problem in oscar.c in function purple_ssi_authrequest. Authorization request comes in UTF-8, but in this function it's convert to UTF-8 (msg -> reason). This is wrong, and this not need to be converted. Also, libpurple send authorization request in UTF-8 (family_feedbag.c function aim_ssi_sendauth). Why it need to be converted? I think this is a mistake.

This is my conclusion too. However, lacking a history of experience with OSCAR (and in particular all the various ICQ clients), I'm not comfortable saying that the solution is just to remove the decoding step (or have the default be Unicode and then also try the value from the account options).

[Korich]

this is patch work good!
now all ok, when take request message on russian lang
thanks xmarchello

to dev - why You not apply it?

[MarkDoliner]

I changed purple_ssi_authrequest to not try to convert the message encoding. This fixes the problem for me in my testing. If there are other places that you see problems then please file specific tickets for them (after searching to make sure there isn't already an existing ticket).

Thanks!

[markdoliner@…]

(In [4f0c3aedc3b013ab2175e57b71bab92988e4f812]):
Don't try to convert the message in incoming auth requests. The oscar protocol documentation that used to be posted on AOL's web site stated that, "All strings in Feedbag are UTF8 encoded." Looks like the current conversion code was added in a59a61f8b5d0874acb16f9ca8e57a074cf037eca

I believe this fixes #7457