Ticket #8162 (closed patch: fixed)

Opened 20 months ago

Last modified 20 months ago

Statuses which are marked as not saveable are still saved

Reported by: tomgr Owned by:
Milestone: 2.5.5 Component: libpurple
Version: 2.5.4 Keywords:
Cc:

Description

It appears that purple_status_type_is_saveable is never called to check if the core statuses should be saved. This means that, in particular, the tune status is saved, and thus stale now playing information can persist after closing and opening the client.

Attachments

saved-statuses.diff (0.8 kB) - added by tomgr 20 months ago.

Change History

Changed 20 months ago by tomgr

Changed 20 months ago by datallah@…

  • status changed from new to closed
  • resolution set to fixed
  • milestone set to 2.5.5

(In [c2797e3aebf59d6216bf8bf5546e6828d238cdde]):
Thomas Gibson-Robinson noticed that the "saveable" attribute of a status type didn't actually do anything (and consequently "non-saveable" status types were being saved). A side effect of fixing this is that we have to change the behavior of purple_status_type_new() to default "saveable" to TRUE in order to maintain the current behavior. Fixes #8162

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!