Ticket #9066 (closed patch: fixed)

Opened 11 months ago

Last modified 9 months ago

Adding and saving animated smileys

Reported by: frasten Owned by: sadrul
Milestone: 2.6.0 Component: pidgin (gtk)
Version: Keywords: animated, smileys, pidgin, add
Cc: datallah

Description (last modified by frasten) (diff)

I've written a patch against the mtn trunk, to allow adding animated custom smileys.

It uses the new structs in [b7a9a556a47e7f06d11e8fcdee75a6bd4b164de3] and reads the new animated smiley cache when the smiley is added, instead of using GdkPixBuf. Please review.

Attachments

add-animated-smileys-v0.5.patch (5.6 kB) - added by frasten 11 months ago.
add-animated-smileys-v0.6.patch (10.9 kB) - added by frasten 10 months ago.
add-animated-smileys-v0.7.patch (4.2 kB) - added by frasten 10 months ago.
New version of the patch, allowing to add an animated smiley to your local custom smileys.

Change History

Changed 11 months ago by frasten

Changed 11 months ago by rekkanoryo

  • milestone set to Patches Needing Review

I am not considering this a blocker for 2.6.0.

Changed 11 months ago by datallah

  • description modified (diff)

Changed 10 months ago by frasten

Changed 10 months ago by frasten

  • description modified (diff)

Now the patch allows saving the custom animated smiley to a file.

Changed 10 months ago by frasten

  • summary changed from Adding animated smileys to Adding and saving animated smileys

Changed 10 months ago by sadrul@…

  • status changed from new to closed
  • resolution set to fixed
  • milestone changed from Patches Needing Review to 2.6.0

(In [b7a9a556a47e7f06d11e8fcdee75a6bd4b164de3]):
Save raw-data for an image when possible.

This makes it possible to save received animated custom smileys, which was not possible before since GTK+ can't save animated GIFs.

Invalidates and Closes #9066.

Changed 10 months ago by frasten

With [b7a9a556a47e7f06d11e8fcdee75a6bd4b164de3] you can save animated smileys to a file, but you can't add them directly (still added as png). My patch allowed this, so please reopen this ticket or make this behavior possible.

Changed 10 months ago by frasten

New version of the patch, allowing to add an animated smiley to your local custom smileys.

Changed 10 months ago by frasten

I've added another patch against the current mnt trunk, it allows you to add an animated smiley. It completes [b7a9a556a47e7f06d11e8fcdee75a6bd4b164de3] and should close this ticket. Please review.

Changed 10 months ago by darkrain42

  • status changed from closed to new
  • resolution fixed deleted

Changed 10 months ago by darkrain42

  • milestone changed from 2.6.0 to Patches Needing Review

Changed 9 months ago by frasten

  • description modified (diff)

Changed 9 months ago by sadrul

  • owner set to sadrul

Changed 9 months ago by sadrul

  • status changed from new to pending

v0.7 patch looks good.

frasten: What name should we use for you in our COPYRIGHT, ChangeLog, commit message etc?

Changed 9 months ago by frasten

  • status changed from pending to new

My name is Andrea Piccinelli. Thank you!

Changed 9 months ago by Andrea Piccinelli <frasten@…>

  • status changed from new to closed
  • resolution set to fixed
  • milestone changed from Patches Needing Review to 2.6.0

(In [75a466dd96590961d154c6e5d131d85bcae642c6]):
Allow adding received animated custom smileys to locale custom smiley collection. Closes #9066.

Note: See TracTickets for help on using tickets.