Opened 10 years ago

Last modified 3 months ago

#10056 new patch

Add ability to insert image in XMPP IM

Reported by: nops Owned by: deryni
Milestone: Patches Needing Improvement Component: XMPP
Version: 2.6.1 Keywords: image
Cc: malu, marsjaninzmarsa, NickBrown

Description

Now, pidgin have CustomSmiley? future, that gives to user ability to send images as smileys. But for XMPP conversation user cant send selected image ("Insert IM Image" button). I wrote the patch for allow user to insert image in XMPP IM.

Attachments (1)

xmpp-insert-image.patch (3.1 KB) - added by nops 10 years ago.
Patch to allow user to insert IM image

Download all attachments as: .zip

Change History (9)

Changed 10 years ago by nops

Patch to allow user to insert IM image

comment:1 Changed 10 years ago by nops

  • Milestone set to Patches Needing Review

comment:2 follow-up: Changed 10 years ago by darkrain42

  • Cc malu added
  • Milestone changed from Patches Needing Review to Patches Needing Improvement

Quoting malu: I think using BoB is not an option for IM images, since it's designed for small pieces of data, to avoid stream negotiating, etc.

I agree.

comment:3 Changed 10 years ago by nops

What XEP is prefer for sending images?

comment:4 Changed 10 years ago by darkrain42

As the size of the image grows, move from BoB to IBB to SOCKS5 Bytestream (IBB is almost certainly good enough for everything), but such a solution needs to follow an XEP (which is not yet written) so that other clients know how to handle such an image (and Pidgin can determine if a specific buddy will support receiving images).

comment:5 Changed 9 years ago by darkrain42

Ticket #6424 has been marked as a duplicate of this ticket.

comment:6 Changed 4 years ago by marsjaninzmarsa

bump.

comment:7 in reply to: ↑ 2 Changed 3 years ago by ipatrol

Replying to darkrain42:

Quoting malu: I think using BoB is not an option for IM images, since it's designed for small pieces of data, to avoid stream negotiating, etc.

I agree.

I would suggest then we use XEP 0096 with possible fallback to XEP 0047 then.

comment:8 Changed 3 months ago by asjoegren

These days clients use XEP-0363, I think? At least that's what Conversations and Gajim do.

I tried installing the plugin here: https://github.com/Junker/purple-xmpp-http-upload - but I can't send, nor see images sent to me from Conversations or Gajim.

Hm.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!