Opened 10 years ago

Closed 8 years ago

Last modified 8 years ago

#10268 closed patch (fixed)

Gadu-Gadu crashes randomly when receiving images over the chat window

Reported by: stranded Owned by: bartosz
Milestone: 2.8.0 Component: Gadu-Gadu
Version: 2.7.3 Keywords: gadu-gadu, images, crash
Cc:

Description

Gadu-Gadu crashes randomly when receiving images over the chat window on Windows 7 x64.

Here's the log: http://stranded.tla.pl/pidgin.RPT

Sometimes it receives images without any problems and sometimes it just hangs and the "stops responding".

Please anyone fix this ;)

Attachments (2)

pidgin.RPT (3.1 KB) - added by stranded 10 years ago.
crash log also here
pidgin-gg-nullpointer-bug.patch (1.1 KB) - added by tomkiewicz 8 years ago.
bug fixed

Download all attachments as: .zip

Change History (11)

Changed 10 years ago by stranded

crash log also here

comment:1 Changed 9 years ago by Robby

  • Status changed from new to pending

Does this remain a problem in Pidgin 2.7.3?

comment:2 Changed 9 years ago by stranded

  • Status changed from pending to new

Yes

comment:3 Changed 9 years ago by Robby

  • Version changed from 2.6.2 to 2.7.3

Thanks

comment:4 Changed 8 years ago by tomkiewicz

Does it depend from image size? And this problem still exists in 2.7.11? If yes - it may be the same problem as in #13554 (uninitialized ev->event.msg.*).

Changed 8 years ago by tomkiewicz

bug fixed

comment:5 Changed 8 years ago by tomkiewicz

Thanks to crash log, I have finally found that bug.

In ggp_recv_image_handler() we have ev->event union with "image_reply" part used. But the current (before patch) code used "msg" part with uninitialized "time" field. Under linux it taken effect in incorrect date in message log, but under Windows it (as stranded said) caused crash (because of dereferencing NULL pointer).

Now it works fine for me (date in the message log is now correct).

comment:6 Changed 8 years ago by tomkiewicz

And it's not related with #13554, as I thought before.

comment:7 Changed 8 years ago by Robby

  • Milestone set to Patches Needing Review
  • Type changed from defect to patch

comment:8 Changed 8 years ago by tomkiewicz@…

  • Milestone changed from Patches Needing Review to 2.8.0
  • Resolution set to fixed
  • Status changed from new to closed

(In 34e58af0641f94590b330aab30e8e57af2410ae3):
gg: Fix a null pointer dereference.

This null pointer dereference caused a crash on Windows. Curiously, however, it resulted in an incorrect timestamp in the message log (no crash) on Linux.

Fixes #10268.

comment:9 Changed 8 years ago by rekkanoryo@…

(In 5087ae3da67c78c371451923ff256caacaac370d):
Credit Tomasz for his patch. Refs #10268.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!