Opened 10 years ago

Last modified 8 years ago

#10538 new patch

Automaticaly wrap menu in buddy list window

Reported by: Vadim_Druzhin Owned by: deryni
Milestone: Patches Needing Review Component: pidgin (gtk)
Version: 2.6.3 Keywords: menu buddy list

Description (last modified by Vadim_Druzhin)

When using russian localization, main menu in buddy list window is too long. This patch allows menu bar to shorten automatically when window is resized, by moving some of menu items to submenu. See also tickets #7574, #8859.

Attachments (2)

pidgin-2.6.3-menubar.patch (4.8 KB) - added by Vadim_Druzhin 10 years ago.
Patch against pidgin 2.6.3
buddy-wrap.png (66.6 KB) - added by Vadim_Druzhin 10 years ago.
Screenshot with wrapped menu

Download all attachments as: .zip

Change History (5)

Changed 10 years ago by Vadim_Druzhin

Patch against pidgin 2.6.3

Changed 10 years ago by Vadim_Druzhin

Screenshot with wrapped menu

comment:1 in reply to: ↑ description Changed 10 years ago by Vadim_Druzhin

  • Description modified (diff)

comment:2 Changed 10 years ago by rekkanoryo

  • Milestone set to Patches Needing Review
  • Owner set to deryni

Etan, I seem to remember us rejecting this idea on numerous occasions, but I'd like your input.

comment:3 Changed 8 years ago by deryni

(I swear I commented on this at the time, though apparently not here, and my answer at this point is different than it was then.)

We've rejected this in the past on the principal that it is something that GTK+ should really be handling for us and not something we should be doing ourselves.

That being said, I'm less opposed to this now than I was previously.

As written the patch looks fairly good (though there are some stylistic things that would want touching up, including moving menu_extra to the private struct). I can't comment on the GTK+ size calculation bits directly as I'm not familiar with the sizing/allocation mechanism involved at the moment but the rest of it looks pretty good.

We would need to make sure it works correctly when menu-tray icons are present but it looks like it has code to handle that case.

I do wonder if it might make more sense to look into writing our own version of the menu widget instead of hacking this in this way.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!