Opened 10 years ago

Closed 9 years ago

#10709 closed patch (fixed)

gevolution - Evolution now supports more IM types than plugin.

Reported by: cedel Owned by:
Milestone: 2.7.4 Component: plugins
Version: 2.6.3 Keywords: plugin gevolution Evolution IM
Cc:

Description

Since Evolution (2.26.3 Fedora 11 and probably earlier) address book now supports GaduGadu? and Skype in IM fields, might be worth adding these to the plugin, so they synchronise correctly - now, when skype4pidgin plugin exists.

Attachments (2)

gevolution_gg.diff (5.1 KB) - added by deryni 10 years ago.
gevolution_gg_skype.diff (7.7 KB) - added by cedel 10 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by deryni

  • Milestone set to Patches Needing Review
  • Type changed from enhancement to patch

I'm attaching a patch which may (or may not) be enough to support this, I'm not entirely sure. I don't use evolution at all. Feel free to give it a try and let me know if it works.

Changed 10 years ago by deryni

comment:2 Changed 10 years ago by cedel

Thanks very much - actually, I tried to make one of my own before you posted this one (I'm sorry, I'm no programmer and didn't know if it's going to work - attached) which I tested with F11 Pidgin 2.6.3-2 (for the ease of building the package) and I found these points:

  1. we basically came to the same solution
  1. adding buddy to Evolution address book basically works (buddy context menu -> Add to address book -> associate buddy) - checked with Skype contacts, have no GG account-buddies. If the buddy already is in any Evo address book, "Add to address book" disapears - which is probably correct. No user details in the appropriate part of the window, though (don't think it's because of this patch).
  1. In "Buddies -> Add buddy", I can see the contacts from address book, along with their protocols (ICQ, XMMP, Skype, GG). There are some problems with this window (the group selector is malformed, disconnected from the frame) and if I try to add a buddy from the address book to Pidgin buddy list, the contact ends in correct selected group, but always with ICQ protocol - again, this happens even without the patch.

So, generally, the patch seems to work (sorry again - tested only my version, was really looking for the Skype contacts), there are some, most likely unrelated (they are present even in the unpatched version), problems with gevolution.

Also, I recall there were some problems reported with GaduGadu? and gevolution some time ago...

Will see if I can find the source of any of these problems when I have more free time... meanwhile, can somebody else give it a try?

Changed 10 years ago by cedel

comment:3 follow-ups: Changed 10 years ago by deryni

File separate tickets for any gevolution bugs please, it makes things easier to track.

We do not like nor support the skype plugin itself and I'm not inclined to have the gevolution plugin do so.

If the GG part of this patch seems like it would work then it can probably be committed. My only concern is that I have no idea when the GG stuff was added to libebook and wouldn't want to break compilation of the plugin for people who may still have too old of a version (the evolution/libebook sources and documentation didn't seem to have any indication of the version it was added in that I could find).

comment:4 in reply to: ↑ 3 Changed 10 years ago by cedel

Replying to deryni:

Sorry for the delay :(

File separate tickets for any gevolution bugs please, it makes things easier to track.

Will do so.

We do not like nor support the skype plugin itself and I'm not inclined to have the gevolution plugin do so.

I do understand that you don't support the skype plugin itself but may I ask you to reconsider supporting it in gevolution?

  1. It doesn't require the skype plugin to be installed.
  2. If the skype plugin is not installed (there's no account with skype protocol), the functionality doesn't manifest itself anywhere (with the exception of source code), so there's no pushing of the user to use it.
  3. It would act as an "interface" between to other pieces of GPL'ed software (skype plugin, evolution), so there should be no legal issues (I'm no lawyer).
  4. Not supporting it in gevolution won't stop people from using skype plugin and supporting it doesn't make them use it - I think it would just save work to a few people.

If the GG part of this patch seems like it would work then it can probably be committed. My only concern is that I have no idea when the GG stuff was added to libebook and wouldn't want to break compilation of the plugin for people who may still have too old of a version (the evolution/libebook sources and documentation didn't seem to have any indication of the version it was added in that I could find).

According to changelog, Gadu-Gadu fields were added 2006-07-24 and Skype fields were added 2008-08-12 - in case this worries you, it should be possible to add a check on existence of the fields in evo.

I'm more worried about this: Tickets: #973 ... (I have GG account enabled and it seems to work, but I've got no GG buddies).
Is that why GG was removed from the plugin?

comment:5 in reply to: ↑ 3 Changed 9 years ago by QuLogic

Replying to deryni:

If the GG part of this patch seems like it would work then it can probably be committed. My only concern is that I have no idea when the GG stuff was added to libebook and wouldn't want to break compilation of the plugin for people who may still have too old of a version (the evolution/libebook sources and documentation didn't seem to have any indication of the version it was added in that I could find).

deryni, GG was added all the way back in 2006. I believe that's e-d-s 1.7.90, but I'm not sure if that's unstable or something. Is that old enough?

comment:6 Changed 9 years ago by deryni@…

  • Milestone changed from Patches Needing Review to 2.7.4
  • Resolution set to fixed
  • Status changed from new to closed

(In d0cbcbb1a25505fd8801dd556c1ec42e98414c9a):
Add GG support to gevolution. rekkanoryo feels that we require a new enough GLib/GTK+ that the time that this was added to evolution is irrelevant.

Fixes #10709.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!