Opened 9 years ago

Last modified 9 years ago

#10897 new patch

"View Log" (History) does not support Conference Chats (Multi-user chats)

Reported by: dk016926 Owned by: sadrul
Milestone: Patches Needing Improvement Component: pidgin (gtk)
Version: 2.5.5 Keywords: Conference History Log
Cc: michal.jarmolkowicz@…

Description

Even though the history for conference chats is stored in files, it is not possible to retrieve content using the Buddies/View? User Log menu item

Attachments (1)

chat_log_viewer.patch (4.7 KB) - added by Mahfuz 9 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 9 years ago by salinasv

  • Milestone set to Patches Needing Review
  • Owner set to sadrul
  • Type changed from enhancement to patch

comment:2 Changed 9 years ago by sadrul

We cannot really use the current 'View User Log' menu and the structs because we expose PidginBuddyCompletionEntry and PidginFilterBuddyCompletionEntryFunc to plugins, and we would need to break existing plugins that are using these if we wanted to accommodate chats in the same structure.

Instead, I think we should have a separate 'View Chat Log' menu item to popup a dialog where only chat names will be included in the suggestion list. We can start with no filtering for the moment (which you are doing in the patch), and perhaps add it later.

Some notes on the patch:

  • 'normname' should be freed when '!is_found'. (gtkdialogs.c)
  • 'chat_name' should be freed. (gtkdialogs.c, gtkutils.c)

comment:3 Changed 9 years ago by sadrul

  • Milestone changed from Patches Needing Review to Patches Needing Improvement

Changed 9 years ago by Mahfuz

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!