Opened 6 years ago

Closed 5 years ago

#10986 closed enhancement (fixed)

Support XMPP MUC history backlog control

Reported by: Zash Owned by: deryni
Milestone: 2.7.11 Component: XMPP
Version: 2.6.4 Keywords: muc history
Cc:

Attachments (3)

MUCHistoryLimit.diff (2.0 KB) - added by xnyhps 5 years ago.
Patch I made to add functionality in libpurple for this.
MUCHistoryLimit.2.diff (2.5 KB) - added by xnyhps 5 years ago.
Improved the patch, now it tries to parse, and always produces a valid datetime-string, or it doesn't add that field.
10986.patch (4.2 KB) - added by darkrain42 5 years ago.
Corrected version of the patch that is what I was about to commit

Download all attachments as: .zip

Change History (10)

comment:1 Changed 6 years ago by Zash

  • Description modified (diff)

comment:2 Changed 5 years ago by xnyhps

I attached a patch to do the libpurple part of this, for #a14219. Maybe Pidgin wants an interface to configure it, or only request the messages that are necessary, but as I have no experience with Gtk I'll leave that for someone else.

Changed 5 years ago by xnyhps

Patch I made to add functionality in libpurple for this.

comment:3 Changed 5 years ago by darkrain42

  • Milestone set to 2.7.11

Both deryni and I have given this a quick pass in the MUC.

My one open question (and I'm leaning toward 'no') is whether we should try validating the passed-in values (mostly 'since' as a dateTime).

Changed 5 years ago by xnyhps

Improved the patch, now it tries to parse, and always produces a valid datetime-string, or it doesn't add that field.

comment:4 Changed 5 years ago by xnyhps

I've updated the patch, it now parses the "since" field first, and then makes a properly formatted string.

comment:5 Changed 5 years ago by darkrain42

I was about to commit this, but I realized I couldn't explain why maxchars, maxstanzas, and seconds are treated as strings atm (short of code simplicity). Delaying until xnyhps is available, but I'm attaching to this ticket an updated/corrected version of the patch (along with changelog).

Changed 5 years ago by darkrain42

Corrected version of the patch that is what I was about to commit

comment:6 Changed 5 years ago by darkrain42

After discussing this with xnyhps, I realized that the components hash table is always expecting strings.

comment:7 Changed 5 years ago by darkrain42@…

  • Resolution set to fixed
  • Status changed from new to closed

(In a81c5245795dd1fa56db435c6c4d98cd68c7acc9):
jabber: Support for requesting limited history when joining a MUC.

Patch from xnyhps, with some minor corrections by me. Fixes #10986. Refs #a14219.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!