Opened 12 years ago

Closed 8 years ago

Last modified 8 years ago

#1131 closed patch (fixed)

delete buddy should ask to delete buddy pounce

Reported by: bjlockie Owned by: darkrain42
Milestone: 2.8.0 Component: pidgin (gtk)
Version: 2.0 Keywords:
Cc: Dawudd, kartikmohta

Description

When a buddy is deleted and a buddy pounce exists, pidgin should ask if the buddy pounce should also be deleted.

Attachments (1)

remove-buddy-pounces-when-buddy-removed.patch (2.6 KB) - added by kartikmohta 9 years ago.
Just deletes the pounces when the buddy is removed without asking.

Download all attachments as: .zip

Change History (14)

comment:1 follow-up: Changed 12 years ago by sadrul

  • pending changed from 0 to 1

Why would a user want to delete the buddy, but not the pounces for the buddy?

comment:2 in reply to: ↑ 1 Changed 12 years ago by bjlockie

  • pending changed from 1 to 0

Replying to sadrul:

Why would a user want to delete the buddy, but not the pounces for the buddy?

Don't ask, just delete the pounces then. I got pounces for a buddy I'd deleted.

comment:3 Changed 10 years ago by bernmeister

Is this ticket still relelvent? Can it be closed?

comment:4 Changed 10 years ago by bjlockie

Well, the ticket has been opened for 2 years and the change is still not in pidgin-2.5.8 so I would say it is unlikely to be changed. :-(

It still is a feature request but I guess we can say it was rejected.

comment:5 Changed 10 years ago by deryni

  • Milestone set to Patches welcome

Not rejected, just unhandled. Moving to Patches Welcome.

comment:6 Changed 10 years ago by darkrain42

  • Owner set to darkrain42

Changed 9 years ago by kartikmohta

Just deletes the pounces when the buddy is removed without asking.

comment:7 Changed 8 years ago by kartikmohta

Any comments on the patch?

comment:8 Changed 8 years ago by darkrain42

  • Milestone changed from Patches welcome to 2.8.0

This slipped through the cracks of my (ugh, now over 2000) unread ticket emails. I have a very very minor nitpick (which I'll just correct when committing it, and I mention here only so I remember: purple_blist_get_account accessor), but otherwise this looks fine.

What name/email address should you be credited with?

comment:9 Changed 8 years ago by kartikmohta

Thanks! :)

Name: Kartik Mohta
Email: kartikmohta@…

comment:10 Changed 8 years ago by MarkDoliner

  • Type changed from enhancement to patch

comment:11 Changed 8 years ago by kartikmohta@…

  • Resolution set to fixed
  • Status changed from new to closed

(In 9b0e784ac3a47eb05dd2a6e58588e1ebb7cb5044):
Delete buddy pounces when removing a buddy. Fixes #1131.

comment:12 Changed 8 years ago by rekkanoryo@…

(In c05b56215f08b3f5894d3c0cc75a0bb3b0f99725):
Tweak kartikmohta's patch a bit to use accessors instead of directly accessing struct members, add the @since tag to the doxygen comment in the API addition, and add the API addition to ChangeLog.API. Refs #1131.

comment:13 Changed 8 years ago by rekkanoryo@…

(In 0d2aa8ce178628d9a7819a697e9128bb623244e6):
ChangeLog kartikmohta's patch. Refs #1131.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!