Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#11459 closed patch (fixed)

autoaccept - additional options

Reported by: mrok Owned by: sadrul
Milestone: 2.7.10 Component: plugins
Version: 2.6.6 Keywords:
Cc:

Description

This patch adds two additional options to configure the behavior of the autoaccept plugin:
1) allow the filename escaping to be turned off
2) expand the option to reject all incoming file transfers from people not on one's buddy list into reject/ask/accept, similar to what's done on per-buddy basis

By default, filename escaping is turned on (to match unmodified plugin behavior), while accepting from strangers is set to 'ask'.

While turning filename escaping off or setting autoaccept for strangers could be dangerous, I think both should be configurable for users that might desire such a behavior.

Part 2) of this patch also allows behavior described in Ticket #5741.

Attachments (1)

pidgin-2.6.6-autoaccept.patch (3.4 KB) - added by mrok 9 years ago.

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by mrok

comment:1 Changed 9 years ago by rekkanoryo

  • Owner set to sadrul

comment:2 Changed 9 years ago by QuLogic

  • Keywords autoaccept escape all removed
  • Milestone set to Patches Needing Review

Sadrul!

comment:3 Changed 8 years ago by rekkanoryo

mroc, I'm going to commit this patch. I need at least a name with which to credit you (an e-mail address would be useful too). You can e-mail this information to me at rekkanoryo@… if you'd like.

comment:4 Changed 8 years ago by rekkanoryo

  • Milestone changed from Patches Needing Review to 2.7.10

comment:5 Changed 8 years ago by deryni

This should probably migrate the existing stranger rejection setting if it has been set.

comment:6 Changed 8 years ago by rekkanoryo

Yeah, I had noticed that and figured I'd throw a quick hack or two in to cover it after the initial patch was committed.

comment:7 Changed 8 years ago by rok.mandeljc@…

  • Resolution set to fixed
  • Status changed from new to closed

(In baa654e872c8567c315bbf44cc88345faa9a8ac8):
Add additional options to the autoaccept plugin. Fixes #11459.

comment:8 Changed 8 years ago by rekkanoryo@…

(In 322ea5e330b2ce8591329c42931c0ad8dbbbf2cf):
Migrate the pref the previous commit dropped. Refs #11459.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!