Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11666 closed defect (fixed)

Pidgin crashes when receiving file (ICQ) while logged off

Reported by: leemes Owned by: MarkDoliner
Milestone: 2.7.7 Component: ICQ
Version: 2.6.6 Keywords: file transfer offline
Cc:

Description (last modified by leemes)

I received a file request (ICQ), but I signed off AFTER receiving it because I logged in with another account. After returning to my computer (still being offline on that machine and also offline on the other one), where the file request dialog was still on the screen, I confirmed it (without noticing / remembering that this can't work...) but the save file dialog never appeared and pidgin freezed and has been closed after some time. I can't give any further information but I think this bug can be reproduced quite simple.

Change History (6)

comment:1 Changed 9 years ago by leemes

  • Description modified (diff)

comment:2 Changed 9 years ago by Robby

  • Status changed from new to pending

Does this remain an issue in 2.7.3?

comment:3 Changed 9 years ago by trac-robot

  • Status changed from pending to closed

This ticket was closed automatically by the system. It was previously set to a Pending status and hasn't been updated within 14 days.

comment:4 Changed 9 years ago by MarkDoliner

  • Status changed from closed to new

Definitely still an issue.

comment:5 Changed 9 years ago by markdoliner@…

  • Milestone set to 2.7.7
  • Resolution set to fixed
  • Status changed from new to closed

(In 05ca7c0f8c782c05e9866a9ac6ccc03acc7d2c7f):
Close open requests related to this xfer when the request is canceled locally. For oscar this includes disconnecting when you have an incoming transfer request. Without this change Pidgin will crash if the user tries to interact with the dialog. This change fixes #11666.

Now instead of crashing we'll leak. See the lengthy comment in the code if anyone wants to fix this.

comment:6 Changed 9 years ago by rekkanoryo@…

(In 587b2bb9fe22fc4c15ba1c1ef8175be06025ea9d):
Apply Mark's specific changes listed below to the 2.7.7 branch.

* Plucked 05ca7c0f8c782c05e9866a9ac6ccc03acc7d2c7f (markdoliner@…): Close open requests related to this xfer when the request is canceled locally. For oscar this includes disconnecting when you have an incoming transfer request. Without this change Pidgin will crash if the user tries to interact with the dialog. This change fixes #11666.

Now instead of crashing we'll leak. See the lengthy comment in the code if anyone wants to fix this.

* Plucked 089c261f1de00667abd623ce3c5b471e91b09016 (markdoliner@…): I noticed a NULL printf crash from the first chunk of this change. In the second chunk I changed the code to match the error message from the first chunk. I prefer this message.

* Plucked 6e8da78b6e5ccdafa85c8afebff37e426d9a58d3 (markdoliner@…): Move the call to flap_connection_schedule_destroy from oscar_chat_kill to oscar_chat_leave. This avoids having flap_connection_schedule_destroy called from purple_connerr, which itself is called by flap_connection_destroy_cb I'm hoping this change fixes #5927, the oscar crash when a flap connection is disconnected.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!