Opened 6 years ago

Last modified 2 years ago

#12085 new patch

Remember language spell check for contact.

Reported by: kanedauy Owned by: EionRobb
Milestone: Component: unclassified
Version: 2.7.1 Keywords: language, spell check, default lenguage
Cc: r7, brolin_empey

Description

Remember language spell check for each contact, so when I stat a chatting session with some contact I had make contact before, the spell check will be set in the language it was set the moment I closed the chat session before.

Attachments (1)

pidgin-gtkspell-save-lang.patch (7.5 KB) - added by tobias 3 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 6 years ago by datallah

Ticket #12155 has been marked as a duplicate of this ticket.

comment:2 Changed 6 years ago by datallah

This isn't possible until the following enhancement to GtkSpell? is made.

comment:3 Changed 6 years ago by r7

Just btw, found Switch Spell plugin (included in The Purple Plugin Pack) where such functionality already working.

comment:4 Changed 4 years ago by datallah

Ticket #15021 has been marked as a duplicate of this ticket.

comment:5 Changed 4 years ago by datallah

Ticket #15035 has been marked as a duplicate of this ticket.

comment:6 Changed 4 years ago by tobias

Just noticed that the get-language function has been added to GtkSpell? in the meanwhile.

Would be really great if one of the developers can take a look at it and check if it is possible to implement this feature.

comment:7 Changed 4 years ago by datallah

The new functionality in gtkspell is in gtkspell3 which is dependent on gtk3.

comment:8 Changed 3 years ago by tobias

I have checked GtkSpell3 and it seems that it can be compiled with Gtk2-only.

So there is the option to adapt Pidgin to work with GtkSpell3 or try to convince and patch GtkSpell2 upstream and wait for a release so it gets the necessary get-language function.

Changed 3 years ago by tobias

comment:9 Changed 3 years ago by tobias

Added some patch that implements persistent spell check language based on GtkSpell3 and Pidgin 2.10.7. Feedback on the patch is appreciated.

comment:10 Changed 3 years ago by Robby

  • Type changed from enhancement to patch

comment:11 Changed 3 years ago by tobias

It would be great to get some feedback on the patch. Besides a generic code review I am especially interested in answers to the following questions:

  • is it OK to change the dependency from GtkSpell2 to GtkSpell3? Should support for GtkSpell3 be made optional?
  • is it OK to target the patch at Pidgin version 2.10.x? I would prefer if the issue could be solved within the 2.x series instead of waiting for 3.0.

comment:12 Changed 3 years ago by rekkanoryo

  • Owner changed from rekkanoryo to EionRobb

comment:13 Changed 2 years ago by tobias

Any comments?

comment:14 Changed 2 years ago by hansaplast

I don't know if the patch is already included in pidgin 2.10.9, but language is still not remembered for contacts in this version.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!