Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#12207 closed patch (fixed)

some IRC commands don't transcode their arguments to server's encoding

Reported by: ulidtko Owned by: elb
Milestone: 2.7.3 Component: IRC
Version: 2.7.1 Keywords:
Cc:

Description

When using Pidgin's IRC component with a server with non-UTF-8 encoding, some /slash-commands perform poorly on non-ascii arguments. While sending messages and most commands, like changing /nick, setting /topic, making /whois on strings in national charset work just perfectly, it gets impossible to use /mode and /quote commands on similar inputs. In such cases the server replies about apparently ill-transcoded trash sent to it; pure ascii inputs work well.

Attached patch fixes this issue.

Attachments (1)

pidgin-irc-mode_quote-transcoding.patch (1.0 KB) - added by ulidtko 9 years ago.
Patch which makes /mode and /quote IRC commands transcode their arguments to server's encoding

Download all attachments as: .zip

Change History (5)

Changed 9 years ago by ulidtko

Patch which makes /mode and /quote IRC commands transcode their arguments to server's encoding

comment:1 follow-up: Changed 9 years ago by elb

Good catch, and this fix is absolutely correct.

May I have a name and email address with which to credit you in the commit?

comment:2 in reply to: ↑ 1 Changed 9 years ago by ulidtko

Replying to elb:

Good catch, and this fix is absolutely correct.

May I have a name and email address with which to credit you in the commit?

max ulidtko <ulidtko@…>

Thanks for fast reviewing!

comment:3 Changed 9 years ago by ulidtko@…

  • Milestone set to 2.7.2
  • Resolution set to fixed
  • Status changed from new to closed

(In 51236278b5344e58692ae671bd25a862058432da):
Fixes non-ASCII arguments to /mode, /umode, etc. Thanks to Max Ulidtko for this patch.

Fixes #12207

comment:4 Changed 9 years ago by MarkDoliner

  • Milestone changed from 2.7.2 to 2.7.3

This change will actually go out in 2.7.3.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!