Opened 6 years ago

Last modified 22 months ago

#12208 new patch

Finch Irssi window manager draws conversation window at wrong X coordinate

Reported by: btmura Owned by: sadrul
Milestone: Patches Needing Review Component: finch (gnt/ncurses)
Version: 2.7.1 Keywords:
Cc: psig

Description

Changing the window size in a tiling window manager (xmonad) causes the Irssi window manager to redraw the conversation window at the wrong X coordinate. It seems that the coordinates are not wrong, but the ordering of calling move and then resize causes the problem. By changing it to resize and then move, the conversation window redraws at the right X coordinate.

Attached patch fixes the issue.

Attachments (1)

finch-irssi-redraw.patch (870 bytes) - added by btmura 6 years ago.

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by btmura

comment:1 Changed 6 years ago by QuLogic

  • Milestone set to Patches Needing Review

comment:2 Changed 5 years ago by DarkDefender

Works for me.

comment:3 Changed 4 years ago by psig

Issue verified to also exist in Ubuntu 12.04 (finch 2.10.3) when resizing a remotely connected putty window attached to a tmux session with finch inside. Patch seems straight forward, reasonable, and works for me. Can't see a reason 3 years of review has been needed. ;-)

Can this patch please be applied or at least reviewed?

Last edited 4 years ago by psig (previous) (diff)

comment:4 Changed 3 years ago by quigleymd

Patch works for me on 2.10.9. I'd really appreciate if it could be considered for inclusion in the source tree.

Just an update, patch still works on 2.10.10-3.fc20. Is there anything I can do to help get this applied to the development version? Thanks!

Last edited 22 months ago by quigleymd (previous) (diff)
Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!