Opened 9 years ago

Closed 8 years ago

#12431 closed patch (fixed)

Patch for MSN crash caused by msn_switchboard_request

Reported by: hanzz Owned by: QuLogic
Milestone: 2.10.0 Component: MSN
Version: 2.7.2 Keywords:
Cc:

Description

Attached crash and log describes the problem:

MsnSwitchBoard *
msn_session_get_swboard(MsnSession *session, const char *username,
						MsnSBFlag flag)
{
....
		swboard = msn_switchboard_new(session);
		swboard->im_user = g_strdup(username);
		msn_switchboard_request_add_user(swboard, username);
....
	return swboard;
}
  1. New switchboard is created
  1. msn_switchboard_request(swboard); is called, but during this call there is problem with connection to MSN network and account is disconnected (switchboard is freed and no longer exists after that function)
  1. non-existing swboard is used => crash

This is more global problem in prpl-msn implementation and my patch fixes just one occurrence, but I would say we can start with my change.

Attachments (4)

crash.txt (7.5 KB) - added by hanzz 9 years ago.
log.txt (1.3 KB) - added by hanzz 9 years ago.
pidgin-2.7.2-msn-request-switchboard.patch (4.0 KB) - added by hanzz 9 years ago.
pidgin-msn-switchboard-2.9.0.patch (4.8 KB) - added by shlomif 8 years ago.
Here is the patch forwarded for pidgin-monotone-HEAD.

Download all attachments as: .zip

Change History (12)

Changed 9 years ago by hanzz

Changed 9 years ago by hanzz

comment:1 Changed 9 years ago by hanzz

  • Component changed from unclassified to MSN
  • Owner changed from rekkanoryo to QuLogic

comment:2 Changed 9 years ago by hanzz

  • Milestone set to Patches Needing Review

comment:3 Changed 9 years ago by salinasv

It looks Ok to me.

comment:4 Changed 8 years ago by rekkanoryo

  • Milestone changed from Patches Needing Review to 2.7.10

With the new MSN code merged, is this patch still relevant? If so, it needs to be shipped in 2.7.10 or rejected.

comment:5 Changed 8 years ago by rekkanoryo

The cmdproc.[ch] stuff in this patch rejects. Please submit an updated patch (or con Masca or QuLogic into fixing it and committing it before 2.7.10).

comment:6 Changed 8 years ago by rekkanoryo

  • Milestone changed from 2.7.12 to 2.8.0

Changed 8 years ago by shlomif

Here is the patch forwarded for pidgin-monotone-HEAD.

comment:7 Changed 8 years ago by shlomif

Hi, I forward ported the patch to the monotone HEAD (pidgin-2.9.0-and-above). Please apply it.

comment:8 Changed 8 years ago by masca@…

  • Resolution set to fixed
  • Status changed from new to closed

(In e4038d4f52e6856643df0bce1488a565385a851f):
Fix a crash when the account is disconnected and we have requested a SB. (Hanzz, ported by shlomif)(Fixes #12431)

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!