Opened 9 years ago

Closed 9 years ago

#12432 closed patch (fixed)

Patch for yahoo crash caused by yahoo_send_p2p_pkt

Reported by: hanzz Owned by: sulabh.dev
Milestone: 2.7.10 Component: Yahoo!/Yahoo! JAPAN
Version: 2.7.2 Keywords:
Cc:

Description

Hi,

attached patch fixes yahoo crash when PurpleAccount? is disconnected after purple_network_listen function call in yahoo_send_p2p_pkt, but before its callback (the callback is then executed on disconnected account which leads to crash).

Attachments (1)

pidgin-2.7.2-yahoo-network-listen.patch (2.7 KB) - added by hanzz 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by hanzz

comment:1 Changed 9 years ago by hanzz

Also, I'm not sure what's the best way to handle situation when yahoo_send_p2p_pkt is called twice in a row (currently I don't call purple_network_listen in that situation), but I think my solution doesn't break anything.

comment:2 Changed 9 years ago by hanzz

  • Component changed from unclassified to Yahoo!/Yahoo! JAPAN
  • Owner changed from rekkanoryo to sulabh.dev

comment:3 Changed 9 years ago by hanzz

  • Milestone set to Patches Needing Review

comment:4 Changed 9 years ago by rekkanoryo

  • Milestone changed from Patches Needing Review to 2.7.10

I agree this doesn't look like it should break anything. I may ship this in 2.7.10.

comment:5 Changed 9 years ago by hanzz@…

  • Resolution set to fixed
  • Status changed from new to closed

(In f99b2d3f38a4c4e2371b93caa74715ee13fa81ba):
Yahoo: Fix a crash that happens when the PurpleAccount? disconnects after purple_network_listen() is called in yahoo_send_p2p_pkt(), but before the callback for purple_network_listen() is called. This solution isn't perfect-- it will almost certainly fall flat on its face if yahoo_send_p2p_packet() is called twice in a row--but doesn't make matters worse. Fixes #12432.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!