Opened 8 years ago

Last modified 8 years ago

#12448 new enhancement

Add different taskbar notifications for CHAT conv wrt PURPLE_MESSAGE_NICK

Reported by: darkmag Owned by: sadrul
Milestone: Component: finch (gnt/ncurses)
Version: 2.7.2 Keywords: finch irc tui
Cc:

Description

I'm currently using finch as my main IM client. I'm using a lot of protocols, including IRC with a lot of channels. It's not really comfortable that I can't see when my nickname is said (ex. "darkmag: hi"), so I've made a small patch that adds one more widget state (GNT_WIDGET_INFO) that is used when the conversation is PURPLE_CONV_TYPE_CHAT and my nick is not pronounced - so the tab is coloured as HIGHLIGHT_D, meaning that there were some messages but nobody said my nick (nothing urgent, so not setting GNT_WIDGET_URGENT flag).

For that I've replaced the gnt_widget_set_urgent(widget) with gnt_widget_set_flags(widget, flags), to be able to set any flags, not only URGENT. Patch attached.

Changelog:

  • Replace gnt_widget_set_urgent() to gnt_widget_set_flags() to support setting any widget flags.
  • Add GNT_WIDGET_INFO flag for tab notification of some unimportant information.
  • PURPLE_CONV_TYPE_CHAT conversation tab highlights GNT_WIDGET_URGENT only on PURPLE_MESSAGE_NICK message flag, otherwise it highlights GNT_WIDGET_INFO (GNT_COLOR_HIGHLIGHT_D).

Attachments (1)

add-info-to-chat.patch (4.5 KB) - added by darkmag 8 years ago.
patch proposed

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by darkmag

patch proposed

comment:1 Changed 8 years ago by darkmag

Sorry for bugging but - any news?

comment:2 Changed 8 years ago by sadrul

Hi! Sorry about the delay in reviewing the patch!

The patch looks mostly OK. We cannot remove gnt_widget_set_urgent, but we can make it call gnt_widget_set_flags with _URGENT flag. (You don't need to resubmit the patch with this change. It's fairly trivial and I can take care of it).

What 'name <email>' should we use for you in the commit log/COPYRIGHT etc.?

comment:3 Changed 8 years ago by darkmag

Thank you very much! Veaceslav Falico darkmag@…

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!