Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#12505 closed patch (fixed)

improve default browser preference

Reported by: sbrabec Owned by: rekkanoryo
Milestone: 2.7.4 Component: unclassified
Version: 2.6.6 Keywords:
Cc:

Description

Pidgin uses "mozilla" as fallback web browser when it is ran outside GNOME environment and there is not default set.

mozilla is not available in most modern distributions.

Patch proposes to change the default to xdg-open (xdg-utils), a Freedesktop desktop neutral launcher wrapper. But hardcoding "firefox" may be an option as well.

Attachments (1)

pidgin-browser-default.patch (456 bytes) - added by sbrabec 9 years ago.
pidgin-browser-default.patch

Download all attachments as: .zip

Change History (9)

Changed 9 years ago by sbrabec

pidgin-browser-default.patch

comment:1 Changed 9 years ago by datallah

  • Milestone set to Patches Needing Review

comment:2 Changed 9 years ago by salinasv

xdg-open needs to be run on kde, gnome, xfce or set the correct BROWSER env variable.

That said, I think it's better, safer and more standard to use "xdg-open" than "mozilla". It would be even better if we add a message in the prefs dialog pointing the BROWSER variable for people not using that DE.

comment:3 Changed 9 years ago by rekkanoryo

As I said in the XMPP conference, I can't make a solid argument against the use of xdg-open by default--so long as we're not making it the only option. That said, I strongly dislike that xdg-open is completely braindead (requires the use of $BROWSER) if you're not using KDE, GNOME, or XFCE.

Additionally, we should probably add Chrome to our list and change Mozilla to Seamonkey.

comment:4 Changed 9 years ago by rekkanoryo

I'm going to apply this change. I need at least a name to credit you with the patch, but an email address would be helpful too.

comment:5 Changed 9 years ago by rekkanoryo@…

(In 605e3104d4da257c5bd0a523e362328583ea8b17):
Modernize the list of browsers a bit by adding Google Chrome and Chromium to the list of possible browsers. Refs #12505.

comment:6 Changed 9 years ago by sbrabec

comment:4: sbrabec = Stanislav Brabec <sbrabec@…>

comment:7 Changed 9 years ago by sbrabec@…

  • Milestone changed from Patches Needing Review to 2.7.4
  • Resolution set to fixed
  • Status changed from new to closed

(In 797486ac38e1183d9c4bb372be167ce9913a3822):
Change default browser for new non-Windows users to xdg-open. Fixes #12505.

comment:8 Changed 9 years ago by rekkanoryo@…

(In 64e02b98551e11e093e4649f1516f3aceaa321e2):
Credit Stanislav for his patch. Refs #12505.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!