Opened 9 years ago

Closed 9 years ago

#12757 closed defect (fixed)

Libpurple sends out two messages for failed file transfers

Reported by: Robby Owned by: malu
Milestone: 2.7.6 Component: libpurple
Version: 2.6.6 Keywords:
Cc:

Description

Reported by user "lofgole" for Adium 1.4b19 in #a14376:

Summary

If a running file transfer is canceled by the chat partner, two notices are generated and shown. The information should be merged into one notice.

Steps to reproduce

  1. Send file to contact.
  2. Contact cancels file transfer while the transfer is running (actually sending data).
  3. Receive two notices where one could provide a better notice.

Expected results

Only show one notice with the action of the contact and the name of the file.

Actual results

Two notices are shown. One telling the user that the file transfer was closed, and one tells the user that the transfere of file file.xyz was closed.


See attached screenshots.

According to wixardy this only happens with XMPP so I'm assigning the ticket to darkrain.

I cannot tell if this issue is present in recent versions, at least the changelog doesn't indicate that.

Attachments (2)

Bildschirmfoto_2010-10-15_um_17_39_23.png (24.5 KB) - added by Robby 9 years ago.
Bildschirmfoto_2010-10-15_um_17_39_38.png (23.4 KB) - added by Robby 9 years ago.

Download all attachments as: .zip

Change History (6)

Changed 9 years ago by Robby

Changed 9 years ago by Robby

comment:1 Changed 9 years ago by darkrain42

  • Status changed from new to pending

Please follow the instructions to get a debug log and attach it to this ticket.

comment:2 Changed 9 years ago by darkrain42

  • Status changed from pending to new

nevermind the debug log. I see why this is happening. IBB code, so bouncing this over to Marcus :D

Marcus, purple_xfer_cancel_remote calls purple_xfer_error, so I don't think you should be calling it directly (then again, I think the error messages from _cancel_{local,remote} suck, so maybe we can avoid calling purple_xfer_cancel_remote?

comment:3 Changed 9 years ago by darkrain42

  • Owner changed from darkrain42 to malu

(repeating that so malu sees it in his email) nevermind the debug log. I see why this is happening. IBB code, so bouncing this over to Marcus :D

Marcus, purple_xfer_cancel_remote calls purple_xfer_error, so I don't think you should be calling it directly (then again, I think the error messages from _cancel_{local,remote} suck, so maybe we can avoid calling purple_xfer_cancel_remote?

comment:4 Changed 9 years ago by malu@…

  • Milestone set to 2.7.6
  • Resolution set to fixed
  • Status changed from new to closed

(In 69e70bd6383836c5ebe78d1da542084bbac2439e):
Don't call purple_xfer_error before purple_xfer_cancel_remote when an error occurs in IBB, avoids double transfer messages on error. Closes #12757

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!