Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12810 closed defect (fixed)

Authorization requests lost if nickname is empty

Reported by: dustin Owned by: MarkDoliner
Milestone: 2.7.5 Component: ICQ
Version: 2.7.4 Keywords: authorization request nickname alias
Cc: ivan.komarov

Description

(May be related to ticket #12783)

Pidgin 2.7.4 shows no reaction to authorization requests if the request comes from an account with an empty nickname field in the ICQ profile. (i.e. no mini dialog asking to accept/deny the request will show up)

It doesn't matter if the request comes from pidgin or another client. Older versions, e.g. pidgin 2.7.0 do not have this problem.

PS: Sorry for first attaching the log file to TipsForBugReports, that's really clueless.

Attachments (1)

icq_authrequest_nodialog.log (2.7 KB) - added by dustin 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by dustin

comment:1 Changed 8 years ago by datallah

  • Cc ivan.komarov added

Ivan, could this be related to the changes that you made?

comment:2 Changed 8 years ago by qulogic@…

(In 7d1c9a75673aed36deaeca9e96975462a68e2dcd):
There seems to be a missing break here. I noticed it in the log, but probably not related. Refs #12810.

comment:3 Changed 8 years ago by ivan.komarov

I'm positive that was me who broke it (in 12ba055ceeb14a00597ed9c99982d8cb3ab6950f). That 'if (info->nick[0] && (utf8 = oscar_utf8_try_convert(account, od, info->nick))) {' line in the commit above appears to be wrong — we should show the dialog even if the nickname is empty or is not a string which we can convert to UTF-8. I don't know what I was thinking, really.

comment:4 Changed 8 years ago by ivan.komarov@…

  • Milestone set to 2.7.5
  • Resolution set to fixed
  • Status changed from new to closed

(In b4c65c273f2934560d9e643a124b31ac2d2328f2):
We should always display the "Authorize buddy?" mini-dialog, even if the buddy doesn't have a non-empty nickname. Fixes #12810.

Also, why the hell did gotalias() return int? That should be void.

comment:5 Changed 8 years ago by rekkanoryo@…

(In f66a462582d88603680b07482658645162a98ed5):
ChangeLog some stuff that should have been, but wasn't. Refs #12810, #11964, #12593, #12768, #12781.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!