Opened 8 years ago

Last modified 7 years ago

#12829 new defect

Smileys with asterisk don't show because they are damaged in gtalk

Reported by: sedaha Owned by: deryni
Milestone: Component: XMPP
Version: 2.7.4 Keywords: smileys asterisk xmpp gtalk
Cc: malu

Description

When receiving smileys such as "*BYE*" or "*THUMBS UP*" , they aren't received properly - always on gmail/gtalk jabber account. In Pidgin 2.7.4. I see them as bold text "BYE*" or "THUMBS UP*" (without first asterisk). In previous version of Pidgin I saw them as bold texts "BYE" or "THUMBS UP" without both asterisks so I suppose it's bug in libpurple rather than in jabber server. It behaves same for every word or sencence so I wonder if there is some functionality in XMPP to make bold text in or if there is missing some escaping.

I have tested between jabber.cz and gtalk account and also between 2 gtalk accounts to confirm that the bug is present only when receiving message from gtalk account.

Attachments (1)

pidgin-debug.txt (1.7 KB) - added by YellowOnion 7 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 follow-up: Changed 8 years ago by deryni

  • Status changed from new to pending

If you are seeing them in bold that means you have the Irssi Features plugin loaded which may be interfering with the normal smiley processing. Try turning that plugin off and seeing what happens.

comment:2 Changed 8 years ago by darkrain42

  • Status changed from pending to new

I think we do actually do some incoming formatting when the receiving account is a Google Talk account (I notice this every once-in-a-while):

        if (jm->js->googletalk && jm->xhtml == NULL) {
            char *tmp = jm->body;
            jm->body = jabber_google_format_to_html(jm->body);
            g_free(tmp);
        }

My guess is that something may have broken in the parsing when Marcus split up google.c into separate files. Which wouldn't actually fix the reported issue here, but would fix the regression in behavior in 2.7.4 :)

comment:3 Changed 8 years ago by darkrain42

  • Cc malu added

comment:4 in reply to: ↑ 1 Changed 8 years ago by sedaha

Replying to deryni:

If you are seeing them in bold that means you have the Irssi Features plugin loaded which may be interfering with the normal smiley processing. Try turning that plugin off and seeing what happens.

I have activated only these standard plugins: autoaccept, history, winprefs, pidginrc, sendbutton, relnot, notify. And so has the other side.

comment:5 Changed 8 years ago by sedaha

Interesting: if I send a custom smiley with name such as *ZZ* then it's received normally by gtalk.

comment:6 Changed 8 years ago by sedaha

Also intereting: combination such as :-)*BYE* is also received normally.

comment:7 Changed 8 years ago by darkrain42

The code that converts into bold, etc, is only done on incoming messages, IIRC, so no matter what, handling of outgoing messages would remain the same between Gtalk and other XMPP accounts.

comment:8 Changed 8 years ago by kentyman

This looks related to #13315.

comment:9 Changed 8 years ago by deryni

Ticket #13315 has been marked as a duplicate of this ticket.

comment:10 Changed 8 years ago by kentyman

My buddy with 2.6.6 is not seeing this problem, BTW.

comment:11 Changed 8 years ago by blinky

I can confirm that this persists in 2.9.0 with regards to formatted (e.g. bolded) text as well. Incoming text is bolded correctly, but only the first asterisk is stripped: the closing asterisk is left in.

comment:12 Changed 7 years ago by YellowOnion

Only happens on non formatted text, if you set color/font it stops the parsing them

version 2.10.0

attaching basic logs

Changed 7 years ago by YellowOnion

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!