Opened 8 years ago

Closed 8 years ago

#12856 closed patch (fixed)

MSN support becomes corrupt on NetBSD and #pragma pack(push, n)

Reported by: KawatoriShinji Owned by: QuLogic
Milestone: 2.7.8 Component: MSN
Version: 2.7.5 Keywords:
Cc:

Description

Running finch 2.7.3 on NetBSD, MSN support becomes corrupt after a while, buddy statuses become inaccurate, and logging fails. Disabling/enabling the account does not fix this, but a restart of finch does. 2.6.x did not have this issue.

When recently updating to 2.7.5, I noticed that there were warnings in the MSN code about #pragma pack(push, n) and #pragma pack(pop) not being supported on the target (x86_64--netbsd). I patched these instances to use __attribute__ ((__packed__)) if __GNUC__ is defined and to use the pragma if _WIN32 is defined.

I do not know something between 2.7.3 fixed the problem or if this patch fixed it, but MSN works fine now; I have been running finch for 5 days with no issue. I haven't had a chance to test my patch on 2.7.3 yet to see if packing was the issue, since I actively use my MSN account.

Attachments (1)

patch-ac (1.7 KB) - added by KawatoriShinji 8 years ago.
Use GCC attributes instead of #pragma for alignment on GCC

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by KawatoriShinji

Use GCC attributes instead of #pragma for alignment on GCC

comment:1 Changed 8 years ago by Dimmuxx

  • Milestone set to Patches Needing Review

comment:2 Changed 8 years ago by qulogic@…

(In 753113a148c133b26f36171d552fcbde0a35c27f):
Change SLP P2P functions to use the new buffer access functions instead of mapping to a struct. I don't mind this since it's limited to just one pair of functions. This means that we don't need to use any packing there.

Refs #12856.

comment:3 Changed 8 years ago by qulogic@…

  • Milestone changed from Patches Needing Review to 2.7.8
  • Resolution set to fixed
  • Status changed from new to closed

(In 84710c18b00e11881bb2eeece1223ace4c0e40fa):
Add functions for reading and writing a MsnFileContext? which negates the need for any more packing.

Fixes #12856.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!