Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13032 closed patch (fixed)

Holding the call does not stop sending audio

Reported by: haakon Owned by: Maiku
Milestone: 2.7.10 Component: Voice and Video
Version: 2.7.7 Keywords: call hold


When you press "Hold" button during the voice call, there is no effect. Media are still being sent through the network. However, holding video with "Pause" works fine.

stream_info_cb() in Farsight2 backend ignores PURPLE_MEDIA_INFO_HOLD and PURPLE_MEDIA_INFO_UNHOLD events, this was probably omitted by mistake. Attached patch handles them analogously to PURPLE_MEDIA_INFO_PAUSE and PURPLE_MEDIA_INFO_UNPAUSE.

Attachments (1)

0001-Stop-sending-media-on-call-hold.patch (1.4 KB) - added by haakon 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by haakon

comment:1 Changed 8 years ago by rekkanoryo

  • Milestone set to Patches Needing Review

comment:2 Changed 8 years ago by darkrain42

  • Milestone changed from Patches Needing Review to 2.7.8

Looks good to me.

comment:3 follow-up: Changed 8 years ago by rekkanoryo

haakon: I'd like to get this patch and #13044 in for 2.7.10. We need a name and an e-mail address to credit you with. Are the name and address you used to register for trac acceptable for this purpose? If not, please provide the correct information (at least a name).

comment:4 in reply to: ↑ 3 Changed 8 years ago by haakon

Replying to rekkanoryo:

Hi rekkanoryo, yes name and e-mail from my Trac account are perfectly acceptable.

comment:5 Changed 8 years ago by jakub.adam@…

  • Resolution set to fixed
  • Status changed from new to closed

(In a1debeea512ab90391be1034e483aaa5523f4e63):
Stop sending audio when placing a call on hold. Fixes #13032.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!