Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13127 closed patch (fixed)

Allow use of numpad PgUp/PgDn in conversation window

Reported by: sik0fewl Owned by:
Milestone: 2.7.10 Component: pidgin (gtk)
Version: 2.7.8 Keywords:
Cc:

Description (last modified by rekkanoryo)

In the conversation window PgUp/PgDn can be used to scroll the conversation window up or down and Ctrl+PgUp/PgDn cycles through the tabs. However, using the PgUp/PgDn keys on the numpad doesn't work.

Adding the GDK_KP_Page_Up/Down events alongside the existing GDK_Page_Up/Down in pidgin/gtkconv.c should fix the problem, I think. I've attached a patch (untested) that does this.

Attachments (1)

kp_page_up.patch (1.3 KB) - added by sik0fewl 8 years ago.
Patch

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by sik0fewl

Patch

comment:1 Changed 8 years ago by sik0fewl

  • Type changed from defect to patch

comment:2 Changed 8 years ago by rekkanoryo

  • Milestone set to 2.7.10

comment:3 Changed 8 years ago by rekkanoryo

This patch seems acceptable. Are the name and e-mail address you used when signing up for trac acceptable to credit you with? If not, please provide at least a name with which to credit you.

comment:4 Changed 8 years ago by sik0fewl

Name is Ryan Flegel and email address is fine. Thanks.

comment:5 Changed 8 years ago by rekkanoryo

  • Description modified (diff)

comment:6 Changed 8 years ago by rflegel@…

  • Resolution set to fixed
  • Status changed from new to closed

(In 0f2181237987a55e6e9b516110ffa2886bb3ccbf):
Allow the use of the numeric keypad's Page Up and Page Down keys in the conversation window. Fixes #13127.

comment:7 Changed 8 years ago by rekkanoryo@…

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!