Opened 8 years ago

Closed 8 years ago

#13182 closed patch (fixed)

vvconfig: Microphone test GUI

Reported by: haakon Owned by:
Milestone: 2.8.0 Component: plugins
Version: 2.7.9 Keywords: vvconfig microphone silence suppression #13180
Cc:

Description

This patch adds to Pidgin's vvconfig plugin a simple dialog, where user can test if the audio input and output that he selected are actually working.

Two parameters can be also adjusted here:

  • Output volume (also changeable during call)
  • Threshold of silence for silence suppression (see ticket #13180)

I developed this feature in conjunction with #13180, but the dialog can also be useful on its own, as there is now no way to try the voice configuration prior the call. If requested, I can split the path.

Attachments (1)

Microphone-test-GUI.patch (7.4 KB) - added by haakon 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by rekkanoryo

  • Milestone set to Patches Needing Review

comment:2 Changed 8 years ago by rekkanoryo

  • Milestone changed from Patches Needing Review to 2.7.10

comment:3 follow-up: Changed 8 years ago by darkrain42

  • Milestone changed from 2.7.11 to Patches Needing Review

haakon: Does this patch need updating to go along with the per-account silence suppression tweaks made in the other patch? It looks like it might?

comment:4 in reply to: ↑ 3 Changed 8 years ago by haakon

Replying to darkrain42:

Does this patch need updating to go along with the per-account silence suppression

I don't think so - you can disable silence suppression per account when it does not work well with that particular protocol, but silence threshold level configured with vvconfig plugin is global for all accounts (same as input volume). This patch should work just fine as it is now.

If you request per-account silence threshold configuration, I can implement it, but I see no benefit in allowing to do that. Most probably you are using the same audio hardware for calls with all your accounts, so tuning the suppression once globally will be enough.

comment:5 follow-up: Changed 8 years ago by rekkanoryo

Can you remake this patch against 2.7.11? The patch rejects for me as it is now, and I want it in for 2.7.12.

Changed 8 years ago by haakon

comment:6 in reply to: ↑ 5 Changed 8 years ago by haakon

Replying to rekkanoryo: Updated patch should be applicable against 2.7.11

comment:7 Changed 8 years ago by jakub.adam@…

  • Milestone changed from Patches Needing Review to 2.8.0
  • Resolution set to fixed
  • Status changed from new to closed

(In c840feed2f7f2bdae47fc679712e4b5504e5acf4):
This patch adds to Pidgin's vvconfig plugin a simple dialog, where user can test if the audio input and output that he selected are actually working.

Two parameters can be also adjusted here:

  • Output volume (also changeable during call)
  • Threshold of silence for silence suppression (see ticket #13180)

I developed this feature in conjunction with #13180, but the dialog can also be useful on its own, as there is now no way to try the voice configuration prior the call. If requested, I can split the path.

Fixes #13182.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!