Opened 12 years ago

Closed 12 years ago

#1324 closed patch (fixed)

Add signals for email notification

Reported by: charkins Owned by: rlaager
Milestone: 2.1.0 Component: pidgin (gtk)
Version: 2.0.1 Keywords:
Cc:

Description

This patch adds signals corresponding to purple_notify_email() and purple_notify_emails(). I've also added appropriate callbacks in the signals-test plugin (though I stop short after displaying 5 emails in response to displaying-emails-notification signal). I have limited experience using email notification, so this could use a little testing from others.

These signals will be necessary to implement sound events for mail notification (ticket #780) and could help in dealing with tickets #530 and #531.

As this adds new API (signals count as API, right?), I'm setting milestone to 2.1.0.

Attachments (1)

notify-emails-signals.patch (6.5 KB) - added by charkins 12 years ago.

Download all attachments as: .zip

Change History (5)

Changed 12 years ago by charkins

comment:1 Changed 12 years ago by rlaager

  • Owner set to rlaager
  • Status changed from new to assigned

comment:2 Changed 12 years ago by rlaager

This seems fine to me. Any reason the count isn't first, though? ...not that it really matters.

comment:3 Changed 12 years ago by charkins

I put it last because there was already a marshal function defined for that signature.

comment:4 Changed 12 years ago by seanegan@…

  • Resolution set to fixed
  • Status changed from assigned to closed

(In 631a6c3a4cb33daf1d436da1b472928ddb14c9de) Email notification signals from charkins. Fixes #1324

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!