Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13259 closed patch (fixed)

Incoming GG messages with richtext formatting may be silently dropped.

Reported by: Hermitifier Owned by: bartosz
Milestone: 2.7.10 Component: Gadu-Gadu
Version: 2.7.9 Keywords: richtext formatting
Cc:

Description

Procedure ggp_recv_message_handler() in file libpurple/protocols/gg/gg.c does not parse event.msg.formats correctly. If field gg_msg_richtext_format.font has bit GG_FONT_COLOR enabled, this struct is followed by struct gg_msg_richtext_color. Libpurple does not take it into account and attempts to cast it onto next gg_msg_richtext_format. Black messages fail safely, but coloured text can lead to whole message being dropped.

Attachments (1)

gg_1l.diff (304 bytes) - added by Hermitifier 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by Hermitifier

comment:1 Changed 8 years ago by Dimmuxx

  • Milestone set to Patches Needing Review
  • Type changed from defect to patch

comment:2 Changed 8 years ago by darkrain42

  • Milestone changed from Patches Needing Review to 2.7.10

Looks fine enough

comment:3 follow-up: Changed 8 years ago by rekkanoryo

Hermitifier, how should you be credited for this patch (name and preferably e-mail address)?

comment:4 in reply to: ↑ 3 Changed 8 years ago by Hermitifier

The name is Jan Zachorowski, and e-mail is quantifier666 at gmail.com.

comment:5 Changed 8 years ago by quantifier666@…

  • Resolution set to fixed
  • Status changed from new to closed

(In a7b6a6e031e4c2be97c878cb74dc5c23e5be445e):
gg: Prevent dropping whole messages when the text is colored. Fixes #13259.

comment:6 Changed 8 years ago by rekkanoryo@…

(In 3f65a3b8249df3c5a8a4e8c365b344516e907c22):
Credit where due. Refs #13259.

comment:7 Changed 8 years ago by kkszysiu

Gratz Hermitifier, I forgot to implement something like that :/

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!