Opened 8 years ago

Last modified 6 years ago

#13541 new patch

Display subjects for messages on XMPP

Reported by: chemistrydioxide Owned by: deryni
Milestone: Patches Needing Review Component: XMPP
Version: 2.10.6 Keywords: subject

Description (last modified by chemistrydioxide)

On XMPP, messages can have subject lines. Here's an example:

<message from='' to=''
 type='normal'><subject>Server will be down for
 maintenance</subject><body>This will happen from 2011-11-21, 12
 hours til 2011-11-22, 13 hours.

Earnest Xonan Ample, Admin</body></message>

When pidgin receives a message of the latter kind, it only displays the message body but not the subject which is a loss of information. In the example above, it would not even become clear what the message is about.

Of course, I don't understand why instant messages should have subject lines like e-mails, but I do think that these should not be silently discarded. I think that the subject line should be displayed as the first line of the message, maybe in bold so it can be recognized as a heading.

Attachments (1)

2013-01-12_jabber_subject_line_patch_v2.diff (2.8 KB) - added by chemistrydioxide 6 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by chemistrydioxide

  • Description modified (diff)

Changed 6 years ago by chemistrydioxide

comment:2 Changed 6 years ago by chemistrydioxide

Ok, so here's a patch that fixes this issue. I have also changed the treatment of subject lines in chat rooms. Previously, these were treated as a topic change; Now, they are treated as part of the message. I think that the subject line of a message should not be regarded as some kind of a subject line of an entire conversation but only as a subject line of that message; Showing it on screen shouldn't cause the topic or parts of earlier messages cause to disappear.

comment:3 Changed 6 years ago by chemistrydioxide

  • Milestone set to Patches Needing Review
  • Version changed from 2.7.11 to 2.10.6

comment:4 Changed 6 years ago by MarkDoliner

  • Type changed from defect to patch
Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!