Opened 8 years ago

Closed 8 years ago

#13580 closed patch (fixed)

Broken sending images support (via Gadu-gadu)

Reported by: tomkiewicz Owned by: bartosz
Milestone: 2.8.0 Component: Gadu-Gadu
Version: 2.7.11 Keywords: images
Cc: rekkanoryo

Description

Sending images (via Gadu-gadu protocol) feature was broken some time ago. At first it doesn't work. At second it crashes Pidgin if we try to send large images.

Steps to reproduce:

  1. start conversation with another gadu-gadu user
  2. attach an image via Chat -> Insert image (i don't know exact translation of "Rozmowa -> Wstaw obraz" in Polish)
  3. press enter - image should appear on conversation log (suggesting that recipient got it)
  4. recipient gets nothing (even not a single empty message)

Another problem:

  1. start conversation like before
  2. attach image larger than 256kB
  3. press enter - Pidgin hangs and gets 50% of (dual core) CPU usage

I found out, where was a bug. It was improper use of pointers. Someone stored (in global hash map) pointer to variable, which was on stack. I replaced pointers with values (i think it was original intention).

Also problem with big images was also solved. There was an infinite loop, probably copy-paste from other part of Pidgin source.

Both fixed and works well for me. Sending images works again, after such a long time :).

Attachments (1)

pidgin-image-send.patch (3.6 KB) - added by tomkiewicz 8 years ago.
Restores image sending via Gadu-gadu

Download all attachments as: .zip

Change History (3)

Changed 8 years ago by tomkiewicz

Restores image sending via Gadu-gadu

comment:1 Changed 8 years ago by Robby

  • Milestone set to 2.8.0

comment:2 Changed 8 years ago by rekkanoryo@…

  • Resolution set to fixed
  • Status changed from new to closed

(In 5ae02f9359383aa843dd30fc25c0e264c120d422):
Gadu-Gadu: Fix sending inline images to remote users. Also fix sending images larger than 256 KB. Fixes #13580.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!