Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13590 closed enhancement (fixed)

Full typing notifications support in GaduGadu

Reported by: kkszysiu Owned by: bartosz
Milestone: 2.8.0 Component: Gadu-Gadu
Version: 2.7.11 Keywords: typing, notification
Cc:

Description

There's it! Full support for both receiving and sending typing notifications from/to buddies. Enjoy!

Attachments (5)

typing_notify.patch (8.7 KB) - added by kkszysiu 8 years ago.
gg_typing_patch.patch (1.8 KB) - added by kkszysiu 8 years ago.
gg_typing_patch.2.patch (1.4 KB) - added by tomkiewicz 8 years ago.
my point of view on that code
gg_typing_patch.3.patch (1.4 KB) - added by tomkiewicz 8 years ago.
Code polishing
gg_typing_patch.4.patch (1.6 KB) - added by tomkiewicz 8 years ago.
Added support for PURPLE_NOT_TYPING

Download all attachments as: .zip

Change History (19)

Changed 8 years ago by kkszysiu

comment:1 Changed 8 years ago by QuLogic

  • Keywords gadu gadugadu libgadu removed
  • Milestone set to Patches Needing Review

comment:2 Changed 8 years ago by tomkiewicz

This patch doesn't apply well for me against newest version from repository.

Changed 8 years ago by kkszysiu

comment:3 Changed 8 years ago by kkszysiu

Try new patch. Should work :)

comment:4 Changed 8 years ago by tomkiewicz

Works like a charm :).

BUT: I'm not sure, if we should use GG_FEATURE_ALL setting. If it would be proper way, libgadu wouldn't let us to set it (I mean, this would be set by default). I think, we should enumerate all supported features here.

Changed 8 years ago by tomkiewicz

my point of view on that code

comment:5 Changed 8 years ago by tomkiewicz

Also, we don't need to malloc/frees outside "state == PURPLE_TYPING" condition. See my slightly modified version of your patch.

comment:6 Changed 8 years ago by QuLogic

I don't believe there's any reason to strdup at all. You should remove it entirely.

Changed 8 years ago by tomkiewicz

Code polishing

comment:7 Changed 8 years ago by tomkiewicz

Yes, you are right. Also, there is no need to copy GGPInfo pointer before using it.

Changed 8 years ago by tomkiewicz

Added support for PURPLE_NOT_TYPING

comment:8 Changed 8 years ago by tomkiewicz

I have added PURPLE_NOT_TYPING support. That means, when you delete typed message, other gg client will get pencil icon disappeared.

comment:9 Changed 8 years ago by kkszysiu

Will anyone put that into repo?

comment:10 Changed 8 years ago by rekkanoryo

Yes, I will commit it sometime this week or weekend.

comment:11 Changed 8 years ago by kkszysiu

Great, thanks :)

comment:12 Changed 8 years ago by rekkanoryo@…

  • Milestone changed from Patches Needing Review to 2.8.0
  • Resolution set to fixed
  • Status changed from new to closed

(In 3c6138e8de4359530c9a5bde39b23349f754281c):
This patch from kkszysiu and tomkiewicz implements full typing notification support for Gadu-Gadu. Fixes #13590.

comment:13 Changed 8 years ago by deryni

Is there a reason this patch sends random lengths to the network?

If we don't want to expose the actual message length for some reason (I'm not sure we don't but that's something that can get discussed) could we not just always send some static value?

(Or if for some reason that isn't acceptable could we at least swap between two values or constantly increment the value or something less intensive then generating a random number every second we type?)

comment:14 Changed 8 years ago by kkszysiu

I will look into that when I find some time for sure :)

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!