Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#13699 closed patch (fixed)

GG timeout

Reported by: Hermitifier Owned by: bartosz
Milestone: 2.8.0 Component: Gadu-Gadu
Version: 2.7.11 Keywords: ping timeout keepalive
Cc:

Description

Libpurple does not send a keepalive packet if prpl has received data within keepalive interval. GG servers require clients to send ping packets regardless of other traffic. Any contact which generates enough presence/message flood can cause libpurple to be disconnected. Attached a one-liner fix. Solution: GG prpl must not update its last_received field.

Attachments (1)

gg_keepalive.diff (354 bytes) - added by Hermitifier 8 years ago.

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by Hermitifier

comment:1 Changed 8 years ago by Robby

  • Milestone set to Patches Needing Review
  • Type changed from defect to patch

comment:2 Changed 8 years ago by quantifier666@…

  • Milestone changed from Patches Needing Review to 2.8.0
  • Resolution set to fixed
  • Status changed from new to closed

(In eaf694c053ee44f6e6c62f4313af318741b5b8d9):
Don't update last_received when receiving data on gg. Fixes #13699.

comment:3 Changed 8 years ago by rekkanoryo@…

(In 1ba5cd6e086b2ff2f52662999ac88f2512b6873b):
Credit Jan for his patch. Refs #13699.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!