Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#13739 closed defect (fixed)

XML events support and instant update of other users avatars

Reported by: tomkiewicz Owned by: tomkiewicz
Milestone: 3.0.0 Component: Gadu-Gadu
Version: 2.10.4 Keywords: events avatar
Cc:

Description (last modified by rekkanoryo)

Recently I found out a small issue: if another user changes it's avatar, we don't get it updated. New avatar is visible after our reconnect, or after this other user status change.

I found out, that we get these updates in XML event packet, but we don't handle them. XML events can contain:

  • GGLive messages (I think, it's something like tweeter service)
  • notifications about avatar changes
  • notifications about user's new blog entries
  • graphical statuses (I hope we will NOT support this one)

detailed information (in Polish): http://toxygen.net/libgadu/protocol/#ch1.13

I have implemented general support for XML events, so we could provide support for new GaduGadu features in the future. Also, I have fixed that small issue, by implementing avatar change notifications, provided by these events.

Attachments (1)

pidgin-gg-xmlevent-support.patch (4.3 KB) - added by tomkiewicz 8 years ago.
General XML events support with avatar change notifications

Download all attachments as: .zip

Change History (14)

Changed 8 years ago by tomkiewicz

General XML events support with avatar change notifications

comment:1 Changed 8 years ago by tomkiewicz

  • Description modified (diff)

comment:2 Changed 8 years ago by Robby

  • Milestone set to Patches Needing Review
  • Type changed from enhancement to patch

comment:3 Changed 8 years ago by rekkanoryo

  • Description modified (diff)

comment:4 Changed 8 years ago by rekkanoryo@…

(In 9ea6eca6227b844c87458ea25cd26626144aee3a):
Credit Tomasz for another patch and fix up another ChangeLog entry. Refs #13739, #11830.

comment:5 Changed 8 years ago by tomkiewicz

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 8 years ago by Robby

  • Milestone changed from Patches Needing Review to 2.8.0

comment:7 in reply to: ↑ description ; follow-up: Changed 7 years ago by eventsiaarhus

Where can i find the documentation for this ? i cant get it to work.

Anders.

Replying to tomkiewicz:

Recently I found out a small issue: if another user changes it's avatar, we don't get it updated. New avatar is visible after our reconnect, or after this other user status change.

I found out, that we get these updates in XML event packet, but we don't handle them. XML events can contain:

  • GGLive messages (I think, it's something like tweeter service)
  • notifications about avatar changes
  • notifications about user's new blog entries
  • graphical statuses (I hope we will NOT support this one)

detailed information (in Polish): http://toxygen.net/libgadu/protocol/#ch1.13 teambuilding århus I have implemented general support for XML events, so we could provide support for new GaduGadu features in the future. Also, I have fixed that small issue, by implementing avatar change notifications, provided by these events.

comment:8 in reply to: ↑ 7 ; follow-up: Changed 7 years ago by tomkiewicz

  • Milestone 2.8.0 deleted
  • Resolution fixed deleted
  • Status changed from closed to new
  • Version changed from 2.7.11 to 2.10.4

Replying to eventsiaarhus: Seems, that libgadu network doesn't send such events anymore (so this feature is broken now). This needs some investigation - I will handle this during GSoC.

comment:9 in reply to: ↑ 8 Changed 7 years ago by eventsiaarhus

When do you expect this will be resolved ? David.

Replying to tomkiewicz:

Replying to eventsiaarhus: Seems, that libgadu network doesn't send such events anymore (so this feature is broken now). This needs some investigation - I will handle this during GSoC.

comment:10 Changed 7 years ago by tomkiewicz

As I wrote before - probably during GSoC. There is no better estimation.

comment:11 Changed 7 years ago by tomkiewicz

  • Owner changed from bartosz to tomkiewicz
  • Type changed from patch to defect

comment:12 Changed 7 years ago by tomkiewicz

  • Milestone set to 3.0.0
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in 5a0c6582d5b1

XML events support is no longer needed here, because we get avatar notifications from user_data events.

comment:13 Changed 7 years ago by Tomasz Wasilczyk <tomkiewicz@…>

(In [5a0c6582d5b1]):
Gadu-Gadu: refactoring of buddy avatars handling. Fixes #13739, #14305

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!