Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#13859 closed patch (fixed)

[PATCH] another update for NetworkManager 0.9

Reported by: dcbw Owned by:
Milestone: 2.10.2 Component: libpurple
Version: 2.7.11 Keywords:
Cc: salinasv

Description (last modified by Robby)

This patch builds on the previous patch (#13505); there have been some cleanups since then. I missed updating the StateChanged? signal; "StateChange?" has been deprecated since NM 0.9 (2008), and the new name "StateChanged?" has existed since the deprecation (2008), so it should be fine to simply change the signal name. Second there's one other place that I forgot to update the state names; this will have an effect in the future, but not at the moment since NM headers define NM_STATE_CONNECTED = NM_STATE_CONNECTED_GLOBAL right now for backwards compat, plus the other states are not yet used (but will be soon).

Attachments (1)

nm09-more.patch (1.9 KB) - added by dcbw 8 years ago.
Updated patch that keeps both signal names for NM 0.6 and NM 0.7+

Download all attachments as: .zip

Change History (15)

comment:1 Changed 8 years ago by dcbw

  • Description modified (diff)

comment:2 Changed 8 years ago by Robby

  • Description modified (diff)
  • Milestone set to Patches Needing Review
  • Type changed from enhancement to patch

comment:3 Changed 8 years ago by QuLogic

  • Status changed from new to pending

StateChanged has existed since which version, exactly?

comment:4 Changed 8 years ago by trac-robot

  • Status changed from pending to closed

This ticket was closed automatically by the system. It was previously set to a Pending status and hasn't been updated within 14 days.

comment:5 Changed 8 years ago by QuLogic

  • Status changed from closed to new

comment:6 Changed 8 years ago by QuLogic

  • Status changed from new to pending

comment:7 Changed 8 years ago by dcbw

  • Status changed from pending to new

StateChanged? has existed since NetworkManager 0.7, which was released on 27-Nov-2008.

http://ftp.gnome.org/pub/GNOME/sources/NetworkManager/0.7/

comment:8 Changed 8 years ago by dcbw

If you like, however, we can keep the old StateChange? signals as well by simply listening for both. I'll attach a new patch with that.

Changed 8 years ago by dcbw

Updated patch that keeps both signal names for NM 0.6 and NM 0.7+

comment:9 Changed 8 years ago by adrianlang

This patch is necessary for me to get Pidgin 2.9.0 with network-manager 0.9 working, that is: connecting on startup. However, I would suggest to explicitly handle the network states which correspond to ›not connected‹ and default to ›connected‹. This would match the behaviour in other situations where libpurple cannot determine the connectivity.

comment:10 Changed 8 years ago by salinasv

  • Cc salinasv added

comment:11 follow-up: Changed 7 years ago by pva

This patch fixed pidgin's inability to find that network connection is present. Thank you dcbw!

BTW, how to subscribe to this bug report? I'd like to receive notification once this'll be fixed upstream...

comment:12 in reply to: ↑ 11 Changed 7 years ago by QuLogic

Replying to pva:

BTW, how to subscribe to this bug report? I'd like to receive notification once this'll be fixed upstream...

Commenting subscribes you to the ticket.

comment:13 Changed 7 years ago by dcbw@…

  • Milestone changed from Patches Needing Review to 3.0.0
  • Resolution set to fixed
  • Status changed from new to closed

(In 10ead4688e3af4132d454fa3bc241480500651c9):
Support new connection states and signals for NetworkManager 0.9+.

Fixes #13859.

comment:14 Changed 7 years ago by markdoliner@…

  • Milestone changed from 3.0.0 to 2.10.2

(In 5fd6531ce513268ae34115d19ceb07fcf61ffd71):
* Plucked 10ead4688e3af4132d454fa3bc241480500651c9 (dcbw@…): Support new connection states and signals for NetworkManager 0.9+.

Fixes #13859.

Note: See TracTickets for help on using tickets.
All information, including names and email addresses, entered onto this website or sent to mailing lists affiliated with this website will be public. Do not post confidential information, especially passwords!